Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump dependencies for Result and ReactiveSwift #1668

Merged
merged 8 commits into from Jul 24, 2018

Conversation

Projects
None yet
7 participants
@sunshinejr
Copy link
Member

sunshinejr commented May 19, 2018

Fixes #1657.

Edit: This was a live contribution on the Wro Open Source conference, now I see that I forgot about updating the lockfiles, will do that later on :D

@sunshinejr

This comment has been minimized.

Copy link
Member Author

sunshinejr commented Jun 5, 2018

Okay, updated the lockfiles but there is a thing - ReactiveSwift will have a release in a few as there is already 4.0.0-rc.1 so we should watch for the update and probably release a major version as well.
cc @SD10

@SD10

This comment has been minimized.

Copy link
Member

SD10 commented Jun 5, 2018

@sunshinejr I agree we need to make a major release soon. I was pretty much waiting on ReactiveSwift because I thought it was the cause of the CI failures. I don't have time to dig on that one.

I would have time to do stuff related to documentation for the release -- migration guide, making the release, etc.

@SD10

This comment has been minimized.

Copy link
Member

SD10 commented Jul 4, 2018

ReactiveSwift is on 4.0.0-rc.2 now for 20 days 😐

@sunshinejr

This comment has been minimized.

Copy link
Member Author

sunshinejr commented Jul 5, 2018

@SD10 Yeah I was thinking about the beta version with their RC but was thinking that they would probably release a major in a day or two so didn't bother.

@xavierLowmiller

This comment has been minimized.

Copy link

xavierLowmiller commented Jul 11, 2018

Will this release with 12.0? Sooner maybe?

@SD10

This comment has been minimized.

Copy link
Member

SD10 commented Jul 11, 2018

@xaverlohmueller It will release with 12.0

@larryonoff

This comment has been minimized.

Copy link
Contributor

larryonoff commented Jul 18, 2018

please bump ReactiveSwift to 4.0 release in this PR

freak4pc added some commits Jul 23, 2018

@freak4pc freak4pc changed the title Update Result dependency from 3 to 4. Bump dependencies for Result and ReactiveSwift Jul 23, 2018

@freak4pc

This comment has been minimized.

Copy link
Member

freak4pc commented Jul 23, 2018

@sunshinejr Noticed 4.0.0 was released so helped out a bit. Feel free to take it from here :]

@SD10

This comment has been minimized.

Copy link
Member

SD10 commented Jul 23, 2018

@freak4pc Awesome 🙇 I plan on working the 12.0 beta release this weekend

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jul 23, 2018

Codecov Report

Merging #1668 into development will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           development   #1668   +/-   ##
===========================================
  Coverage           90%     90%           
===========================================
  Files                5       5           
  Lines              140     140           
===========================================
  Hits               126     126           
  Misses              14      14

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94119c4...31d2848. Read the comment docs.

@SD10
Copy link
Member

SD10 left a comment

We should add two CHANGELOG entries specifying that we've bumped the minimum versions for these dependencies. Aside from that it LGTM. I can take care of it if no one else does before me

@freak4pc freak4pc force-pushed the sunshinejr:feature/update_result branch from 22b9341 to f198351 Jul 24, 2018

@@ -4,6 +4,10 @@
- **Breaking Change** Added `.custom(String)` authorization case to `AuthorizationType` inside `AccessTokenPlugin`. [#1611](https://github.com/Moya/Moya/pull/1611) by [@SeRG1k17](https://github.com/SeRG1k17).

### Changed
- Minimum version of `ReactiveSwift` is now 4.0.

This comment has been minimized.

@lucas34

lucas34 Jul 24, 2018

Member

Can you add Breaking Change and the pull request id at the end ?

@freak4pc freak4pc force-pushed the sunshinejr:feature/update_result branch from f198351 to f105a4b Jul 24, 2018

@freak4pc freak4pc force-pushed the sunshinejr:feature/update_result branch from f105a4b to 96184ab Jul 24, 2018

@lucas34
Copy link
Member

lucas34 left a comment

LGTM

@sunshinejr

This comment has been minimized.

Copy link
Member Author

sunshinejr commented Jul 24, 2018

Aw, thanks @freak4pc for syncing the PR and thanks to all for taking time to review it! 🧡

I also updated .podspec so it is in sync with newest ReactiveSwift version; please do a final check if you can!

@freak4pc
Copy link
Member

freak4pc left a comment

LGTM

@SD10

SD10 approved these changes Jul 24, 2018

Copy link
Member

SD10 left a comment

:shipit: Thanks everyone~ 💯

@SD10 SD10 merged commit 326bff7 into Moya:development Jul 24, 2018

2 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: carthage_without_swiftlint_integration Your tests passed on CircleCI!
Details

@SD10 SD10 referenced this pull request Nov 2, 2018

Merged

[Release] Moya 12.0 #1753

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.