New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump RxMoya's watchOS deployment target to 3.0 #1758

Merged
merged 4 commits into from Nov 18, 2018

Conversation

Projects
None yet
6 participants
@simonrice
Contributor

simonrice commented Nov 7, 2018

This PR fixes an issue I encountered when building RxMoya for watchOS via Carthage from both development & master on Xcode 10.1.

RxSwift's watchOS deployment target is now at watchOS 3.0 in v4.4.0. As a result, RxMoya fails to build for watchOS via Carthage since its deployment target is at watchOS 2.0. This PR bumps RxMoya's watchOS deployment target to match RxSwift's, allowing a successful build via Carthage.

All other OS deployment targets appear to be fine.

Question: should the sub-podspec for RxMoya also be bumped to watchOS 3.0?

@SD10

This comment has been minimized.

Member

SD10 commented Nov 15, 2018

Hey @simonrice, yes we should bump the version in the podspec as well 👍 Could you please add a CHANGELOG entry under Changed to convey this to users?

@gityubj

This comment has been minimized.

gityubj commented Nov 16, 2018

Please Merge Pull Request Right now!!!

@BasThomas

This comment has been minimized.

Contributor

BasThomas commented Nov 16, 2018

You could always use a fork in the meantime, @gityubj :)

@simonrice simonrice force-pushed the simonrice:hotfix/rxmoya-watchos-bump branch from b4f8ffc to 66e27f7 Nov 16, 2018

@MoyaBot

This comment has been minimized.

MoyaBot commented Nov 16, 2018

1 Warning
⚠️ The Moya.podspec was updated, but there were no changes in Cartfile, Cartfile.resolved, Package.swift and Package.resolved.
Did you forget to update Cartfile, Cartfile.resolved, Package.swift and Package.resolved?
3 Messages
📖 iOS: Executed 254 tests, with 0 failures (0 unexpected) in 11.846 (11.995) seconds
📖 tvOS: Executed 254 tests, with 0 failures (0 unexpected) in 11.043 (11.172) seconds
📖 macOS: Executed 254 tests, with 0 failures (0 unexpected) in 11.292 (11.398) seconds

Generated by 🚫 Danger

@codecov-io

This comment has been minimized.

codecov-io commented Nov 16, 2018

Codecov Report

Merging #1758 into development will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #1758   +/-   ##
============================================
  Coverage        90.83%   90.83%           
============================================
  Files                5        5           
  Lines              131      131           
============================================
  Hits               119      119           
  Misses              12       12

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d1ed87...4ba1266. Read the comment docs.

@SD10

SD10 approved these changes Nov 17, 2018

Just letting CI pass 👍 Thanks for updating this @simonrice

@SD10 SD10 merged commit b791faa into Moya:development Nov 18, 2018

2 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: carthage_without_swiftlint_integration Your tests passed on CircleCI!
Details
@peril-moya

This comment has been minimized.

peril-moya bot commented Nov 18, 2018

@simonrice Thanks a lot for contributing to Moya! We've invited you to join
the Moya GitHub organization – no pressure to accept! If you'd like more
information on what that means, check out our contributor guidelines and
feel free to reach out to @Moya/core-team with any questions.

Generated by 🚫 dangerJS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment