Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Observable.mapImage() returns non-optional image #1799

Merged
merged 1 commit into from Feb 11, 2019

Conversation

Projects
None yet
3 participants
@sunshinejr
Copy link
Member

commented Feb 11, 2019

This is a continuation of #1789. @bjarkehs forgot to update Observable extension and because it was a long time ago I created a complimentary PR.

@MoyaBot

This comment has been minimized.

Copy link

commented Feb 11, 2019

3 Messages
📖 iOS: Executed 254 tests, with 0 failures (0 unexpected) in 11.480 (11.607) seconds
📖 tvOS: Executed 254 tests, with 0 failures (0 unexpected) in 11.097 (11.269) seconds
📖 macOS: Executed 254 tests, with 0 failures (0 unexpected) in 11.532 (11.644) seconds

Generated by 🚫 Danger

@sunshinejr

This comment has been minimized.

Copy link
Member Author

commented Feb 11, 2019

The build error seems to be an issue with CocoaPods linting, gonna open a new PR for that one. Thanks for the review @LucianoPAlmeida!

@sunshinejr sunshinejr merged commit ab76603 into development Feb 11, 2019

1 of 2 checks passed

ci/circleci: build Your tests failed on CircleCI
Details
ci/circleci: carthage_without_swiftlint_integration Your tests passed on CircleCI!
Details

@sunshinejr sunshinejr deleted the feature/observable_mapImage branch Feb 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.