Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix progress object with invalid Content-Length headers. #1815

Merged
merged 5 commits into from Mar 10, 2019

Conversation

Projects
None yet
5 participants
@sunshinejr
Copy link
Member

commented Mar 9, 2019

Fixes #1771.

}

expect(error).to(beNil())
expect(progressValues) == [0, 0, 0, 0, 1.0]

This comment has been minimized.

Copy link
@LucianoPAlmeida

LucianoPAlmeida Mar 9, 2019

Member

This is just curiosity, there is a reason for all moya equal tests use expect(value) == instead of .to(equal(value))?

This comment has been minimized.

Copy link
@sunshinejr

sunshinejr Mar 9, 2019

Author Member

@LucianoPAlmeida I guess I just use it because it's a lot more convenient to just type == instead of .to(equal(value)).

@MoyaBot

This comment has been minimized.

Copy link

commented Mar 9, 2019

1 Warning
⚠️ Consider adding supporting documentation to this change. Documentation can be found in the docs directory.
3 Messages
📖 iOS: Executed 278 tests, with 0 failures (0 unexpected) in 13.202 (13.354) seconds
📖 tvOS: Executed 278 tests, with 0 failures (0 unexpected) in 13.140 (13.299) seconds
📖 macOS: Executed 278 tests, with 0 failures (0 unexpected) in 13.575 (13.700) seconds

Generated by 🚫 Danger

@codecov-io

This comment has been minimized.

Copy link

commented Mar 9, 2019

Codecov Report

Merging #1815 into development will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #1815   +/-   ##
============================================
  Coverage        90.83%   90.83%           
============================================
  Files                5        5           
  Lines              131      131           
============================================
  Hits               119      119           
  Misses              12       12

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4125728...f8c66e2. Read the comment docs.

Show resolved Hide resolved Changelog.md

@sunshinejr sunshinejr merged commit 4480dba into development Mar 10, 2019

2 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: carthage_without_swiftlint_integration Your tests passed on CircleCI!
Details

@sunshinejr sunshinejr deleted the fix/progress_completion branch Mar 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.