Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Xcode 10.2 warnings #1826

Merged
merged 8 commits into from Mar 30, 2019

Conversation

Projects
None yet
7 participants
@larsschwegmann
Copy link
Contributor

commented Mar 29, 2019

Xcode 10.2 introduced some new warnings, which this PR fixes

f-meloni and others added some commits Mar 4, 2019

Merge pull request #1812 from f-meloni/patch-1
Fix proselint on Dangerfile
@MoyaBot

This comment has been minimized.

Copy link

commented Mar 29, 2019

3 Warnings
⚠️ Any changes to library code should be reflected in the Changelog. Please consider adding a note there and adhere to the Changelog Guidelines.
⚠️ Consider adding supporting documentation to this change. Documentation can be found in the docs directory.
⚠️ The library files were changed, but the tests remained unmodified. Consider updating or adding to the tests to match the library changes.
3 Messages
📖 iOS: Executed 254 tests, with 0 failures (0 unexpected) in 11.294 (11.464) seconds
📖 tvOS: Executed 254 tests, with 0 failures (0 unexpected) in 11.185 (11.370) seconds
📖 macOS: Executed 254 tests, with 0 failures (0 unexpected) in 11.352 (11.501) seconds

Generated by 🚫 Danger

@codecov-io

This comment has been minimized.

Copy link

commented Mar 29, 2019

Codecov Report

Merging #1826 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1826   +/-   ##
=======================================
  Coverage   90.83%   90.83%           
=======================================
  Files           5        5           
  Lines         131      131           
=======================================
  Hits          119      119           
  Misses         12       12
Impacted Files Coverage Δ
Sources/RxMoya/MoyaProvider+Rx.swift 96.87% <100%> (ø) ⬆️
Sources/ReactiveMoya/MoyaProvider+Reactive.swift 96.96% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 525f4a6...df435bf. Read the comment docs.

@pedrovereza

This comment has been minimized.

Copy link
Member

commented Mar 29, 2019

Hey @larsschwegmann thanks for taking the time to fix these warnings 🙏

Can you rebase your branch against development and change the target branch for this pr to also be development?

@larsschwegmann

This comment has been minimized.

Copy link
Contributor Author

commented Mar 29, 2019

@sunshinejr sunshinejr changed the base branch from master to development Mar 30, 2019

@sunshinejr
Copy link
Member

left a comment

Awesome, thanks for the PR @larsschwegmann 🚀

@sunshinejr sunshinejr merged commit 8d4933b into Moya:development Mar 30, 2019

2 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: carthage_without_swiftlint_integration Your tests passed on CircleCI!
Details
@peril-moya

This comment has been minimized.

Copy link

commented Mar 30, 2019

@larsschwegmann Thanks a lot for contributing to Moya! We've invited you to join
the Moya GitHub organization – no pressure to accept! If you'd like more
information on what that means, check out our contributor guidelines and
feel free to reach out to @Moya/core-team with any questions.

Generated by 🚫 dangerJS

@BasThomas

This comment has been minimized.

Copy link
Contributor

commented Mar 30, 2019

Can we release a new version that includes this patch? :)

@sunshinejr

This comment has been minimized.

Copy link
Member

commented Mar 30, 2019

@BasThomas yeah gonna release current development most likely tomorrow (as a beta), just need few adjustments beforehand. Tracking it in #1823.

@larsschwegmann

This comment has been minimized.

Copy link
Contributor Author

commented Mar 31, 2019

Thanks for helping me out @sunshinejr 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.