Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RXSwift 5 #1846

Merged
merged 3 commits into from May 2, 2019

Conversation

Projects
None yet
4 participants
@LucianoPAlmeida
Copy link
Member

commented May 1, 2019

Updating RxSwift Dependency to RxSwift 5.0.

@LucianoPAlmeida

This comment has been minimized.

Copy link
Member Author

commented May 1, 2019

Just notice that the development branch is behind master, should we update it?

@MoyaBot

This comment has been minimized.

Copy link

commented May 1, 2019

3 Warnings
⚠️ Any changes to library code should be reflected in the Changelog. Please consider adding a note there and adhere to the Changelog Guidelines.
⚠️ Consider adding supporting documentation to this change. Documentation can be found in the docs directory.
⚠️ The library files were changed, but the tests remained unmodified. Consider updating or adding to the tests to match the library changes.
3 Messages
📖 iOS: Executed 278 tests, with 0 failures (0 unexpected) in 13.090 (13.251) seconds
📖 tvOS: Executed 278 tests, with 0 failures (0 unexpected) in 13.094 (13.236) seconds
📖 macOS: Executed 278 tests, with 0 failures (0 unexpected) in 13.603 (13.770) seconds

Generated by 🚫 Danger

@codecov-io

This comment has been minimized.

Copy link

commented May 1, 2019

Codecov Report

Merging #1846 into development will increase coverage by 1.27%.
The diff coverage is 100%.

Impacted file tree graph

@@              Coverage Diff               @@
##           development   #1846      +/-   ##
==============================================
+ Coverage        92.12%   93.4%   +1.27%     
==============================================
  Files               25      25              
  Lines              864     864              
==============================================
+ Hits               796     807      +11     
+ Misses              68      57      -11
Impacted Files Coverage Δ
Sources/RxMoya/Observable+Response.swift 61.53% <100%> (+7.69%) ⬆️
Sources/RxMoya/Single+Response.swift 100% <100%> (+12.5%) ⬆️
Sources/Moya/Response.swift 95.4% <0%> (+4.59%) ⬆️
Sources/ReactiveMoya/SignalProducer+Response.swift 93.93% <0%> (+9.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c1eb65...1ce020c. Read the comment docs.

@sunshinejr
Copy link
Member

left a comment

Awesome, thanks @LucianoPAlmeida! 🚀

@sunshinejr

This comment has been minimized.

Copy link
Member

commented May 2, 2019

Oh, seems you forgot Changelog entry. I'll make a quick commit so no worries.

@sunshinejr sunshinejr merged commit 639484b into development May 2, 2019

2 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: carthage_without_swiftlint_integration Your tests passed on CircleCI!
Details

@sunshinejr sunshinejr deleted the rxswift-5 branch May 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.