Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Result #1858

Merged
merged 2 commits into from May 15, 2019

Conversation

@larryonoff
Copy link
Contributor

commented May 14, 2019

This PR drops Result dependency.

@larryonoff larryonoff requested a review from sunshinejr May 14, 2019

@larryonoff larryonoff force-pushed the larryonoff:drop-result branch from ec8fe8a to 144af06 May 14, 2019

@sunshinejr
Copy link
Member

left a comment

Awesome, yeah Alamofire 4 still imports Result AFAIK, but this will be removed with version 5 anyways. Thanks for taking care of it, @larryonoff 👍

Changelog.md Outdated Show resolved Hide resolved

@larryonoff larryonoff force-pushed the larryonoff:drop-result branch from 144af06 to cf61a5b May 15, 2019

@MoyaBot

This comment has been minimized.

Copy link

commented May 15, 2019

3 Messages
📖 iOS: Executed 278 tests, with 0 failures (0 unexpected) in 13.671 (13.836) seconds
📖 tvOS: Executed 278 tests, with 0 failures (0 unexpected) in 13.359 (13.555) seconds
📖 macOS: Executed 278 tests, with 0 failures (0 unexpected) in 13.585 (13.742) seconds

Generated by 🚫 Danger

@codecov-io

This comment has been minimized.

Copy link

commented May 15, 2019

Codecov Report

Merging #1858 into development will increase coverage by <.01%.
The diff coverage is 80%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #1858      +/-   ##
===============================================
+ Coverage        92.12%   92.13%   +<.01%     
===============================================
  Files               25       25              
  Lines              864      865       +1     
===============================================
+ Hits               796      797       +1     
  Misses              68       68
Impacted Files Coverage Δ
Sources/Moya/Plugins/NetworkLoggerPlugin.swift 93.44% <ø> (ø) ⬆️
Sources/Moya/Plugin.swift 75% <ø> (ø) ⬆️
Sources/Moya/Plugins/AccessTokenPlugin.swift 100% <ø> (ø) ⬆️
Sources/Moya/MoyaProvider.swift 91.66% <ø> (ø) ⬆️
Sources/Moya/Plugins/NetworkActivityPlugin.swift 100% <ø> (ø) ⬆️
Sources/Moya/Plugins/CredentialsPlugin.swift 100% <ø> (ø) ⬆️
Sources/Moya/MoyaProvider+Internal.swift 97.01% <80%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b560a1...950b244. Read the comment docs.

@sunshinejr

This comment has been minimized.

Copy link
Member

commented May 15, 2019

Alright, it's green, it's merged! 🚀

@sunshinejr sunshinejr merged commit 942c0e9 into Moya:development May 15, 2019

2 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: carthage_without_swiftlint_integration Your tests passed on CircleCI!
Details

@larryonoff larryonoff deleted the larryonoff:drop-result branch May 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.