-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
@ashfurrow => Swift 2.0 #194
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Commented out RxSwift and ReactiveCocoa for now.
- Added @garethknowles `RxSwift` changes to this branch to keep it under one single `PR`. - Credit is still his because I did a rebase
It turns out before it was working with ``` `defer` ``` but not anymore because the signature changed on `RxSwift`; it is now called `deferred`. Everything should be back to normal on `RxSwift` + `Moya` + `Swift 2.0`
- During first exploratoions `Alamofire` was pointing to my local fork of it; now the `Podfile` was changed to point to github and the `swift-2.0` branch specifically.
- Configured «custom» `ReactiveCocoa` `podspec` - Pointing to `swift2` branch - Created custom tag for `ReactiveCocoa` fork - `ReactiveCocoa` framework builds alone --- # Not working: - `ReactiveCocoa` prevents `Pods` from compiling as well as `Moya`
Cool, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #156 (kind of)
This
PR
«branches» from #181PR
with the fixes from @ashfurrow after the transition to an organization (Old was [WIP] Swift 2.0 #162 )Done:
swift-2.0
branchesAlamoFire
swift-2.0
branch as wellRxSwift
ReactiveCocoa
toswift2
branchpodspec
forswift2
branch firstTODO:
ReactiveCocoa
pod compile correctly with the rest of the project.