Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@ashfurrow => Swift 2.0 #194

Merged
merged 14 commits into from Aug 20, 2015
Merged

@ashfurrow => Swift 2.0 #194

merged 14 commits into from Aug 20, 2015

Conversation

esttorhe
Copy link
Member

@esttorhe esttorhe commented Aug 20, 2015

Fix #156 (kind of)

This PR «branches» from #181

  • New PR with the fixes from @ashfurrow after the transition to an organization (Old was #162 )

Done:

  • Currently using Quick and Nimble swift-2.0 branches
  • AlamoFire swift-2.0 branch as well
  • Moya Core is compiling
  • Minimal Swift 2.0 migration (not reworked; only made it compile)
  • @garethknowles migrated the code for RxSwift
  • Migrate ReactiveCocoa to swift2 branch
    • Generate a podspec for swift2 branch first

TODO:

  • Make the generated ReactiveCocoa pod compile correctly with the rest of the project.

Gareth Knowles and others added 14 commits Aug 7, 2015
- Commented out RxSwift and ReactiveCocoa for now.
- Added @garethknowles `RxSwift` changes to this branch to keep it under one single `PR`.
- Credit is still his because I did a rebase
It turns out before it was working with ``` `defer` ``` but not anymore because the signature changed on `RxSwift`; it is now called `deferred`.

Everything should be back to normal on `RxSwift` + `Moya` + `Swift 2.0`
- During first exploratoions `Alamofire` was pointing to my local fork of it; now the `Podfile` was changed to point to github and the `swift-2.0` branch specifically.
- Configured «custom» `ReactiveCocoa` `podspec`
- Pointing to `swift2` branch
- Created custom tag for `ReactiveCocoa` fork
- `ReactiveCocoa` framework builds alone

---

# Not working:
- `ReactiveCocoa` prevents `Pods` from compiling as well as `Moya`
ashfurrow added a commit that referenced this issue Aug 20, 2015
@ashfurrow ashfurrow merged commit 9bf05cc into Moya:swift-2.0 Aug 20, 2015
1 check failed
@ashfurrow
Copy link
Member

@ashfurrow ashfurrow commented Aug 20, 2015

Cool, thanks!

@esttorhe esttorhe deleted the swift-2.0 branch Aug 20, 2015
This was referenced Aug 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants