Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set baseUrl for Octokit to make it work on GitHub Enterprise Server #144

Merged
merged 2 commits into from
Sep 27, 2024

Conversation

palloberg
Copy link
Contributor

Fixes #143

@sylvestre
Copy link
Collaborator

thanks!
do you need a new release?

@sylvestre sylvestre merged commit ff4a61d into Mozilla-Actions:main Sep 27, 2024
7 checks passed
@palloberg
Copy link
Contributor Author

thanks! do you need a new release?

I think so, unless the dist/ files are rebuilt on the main branch so I can use Mozilla-Actions/sccache-action@main

@palloberg palloberg deleted the set-baseurl branch September 27, 2024 09:23
renovate bot added a commit to spiraldb/vortex that referenced this pull request Sep 27, 2024
…942)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
|
[mozilla-actions/sccache-action](https://redirect.github.com/mozilla-actions/sccache-action)
| action | patch | `v0.0.5` -> `v0.0.6` |

---

### Release Notes

<details>
<summary>mozilla-actions/sccache-action
(mozilla-actions/sccache-action)</summary>

###
[`v0.0.6`](https://redirect.github.com/Mozilla-Actions/sccache-action/releases/tag/v0.0.6)

[Compare
Source](https://redirect.github.com/mozilla-actions/sccache-action/compare/v0.0.5...v0.0.6)

##### What's Changed

- fix: string interpolation by
[@&#8203;i10416](https://redirect.github.com/i10416) in
[Mozilla-Actions/sccache-action#122
- Keep GitHub Actions up to date with GitHub's Dependabot by
[@&#8203;cclauss](https://redirect.github.com/cclauss) in
[Mozilla-Actions/sccache-action#131
- fix: avoid downloading package when local cache exists by
[@&#8203;i10416](https://redirect.github.com/i10416) in
[Mozilla-Actions/sccache-action#123
- Set baseUrl for Octokit to make it work on GitHub Enterprise Server by
[@&#8203;palloberg](https://redirect.github.com/palloberg) in
[Mozilla-Actions/sccache-action#144

##### dependencies

- Bump eslint-plugin-jest from 28.5.0 to 28.6.0 by
[@&#8203;dependabot](https://redirect.github.com/dependabot) in
[Mozilla-Actions/sccache-action#130
- Bump ts-jest from 29.1.4 to 29.2.2 by
[@&#8203;dependabot](https://redirect.github.com/dependabot) in
[Mozilla-Actions/sccache-action#134
- Bump [@&#8203;types/node](https://redirect.github.com/types/node) from
20.13.0 to 20.14.11 by
[@&#8203;dependabot](https://redirect.github.com/dependabot) in
[Mozilla-Actions/sccache-action#133
- Bump
[@&#8203;typescript-eslint/eslint-plugin](https://redirect.github.com/typescript-eslint/eslint-plugin)
from 7.8.0 to 7.16.1 by
[@&#8203;dependabot](https://redirect.github.com/dependabot) in
[Mozilla-Actions/sccache-action#132
- Bump typescript from 5.4.5 to 5.5.3 by
[@&#8203;dependabot](https://redirect.github.com/dependabot) in
[Mozilla-Actions/sccache-action#128
- Bump ts-jest from 29.2.2 to 29.2.5 by
[@&#8203;dependabot](https://redirect.github.com/dependabot) in
[Mozilla-Actions/sccache-action#141
- Bump eslint-plugin-prettier from 5.1.3 to 5.2.1 by
[@&#8203;dependabot](https://redirect.github.com/dependabot) in
[Mozilla-Actions/sccache-action#140
- Bump prettier from 3.3.2 to 3.3.3 by
[@&#8203;dependabot](https://redirect.github.com/dependabot) in
[Mozilla-Actions/sccache-action#136
- Bump typescript from 5.5.3 to 5.6.2 by
[@&#8203;dependabot](https://redirect.github.com/dependabot) in
[Mozilla-Actions/sccache-action#145

##### New Contributors

- [@&#8203;i10416](https://redirect.github.com/i10416) made their first
contribution in
[Mozilla-Actions/sccache-action#122
- [@&#8203;cclauss](https://redirect.github.com/cclauss) made their
first contribution in
[Mozilla-Actions/sccache-action#131
- [@&#8203;palloberg](https://redirect.github.com/palloberg) made their
first contribution in
[Mozilla-Actions/sccache-action#144

**Full Changelog**:
Mozilla-Actions/sccache-action@v0.0.5...v0.0.6

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR was generated by [Mend Renovate](https://mend.io/renovate/).
View the [repository job
log](https://developer.mend.io/github/spiraldb/vortex).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC45Ny4wIiwidXBkYXRlZEluVmVyIjoiMzguOTcuMCIsInRhcmdldEJyYW5jaCI6ImRldmVsb3AiLCJsYWJlbHMiOltdfQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@palloberg
Copy link
Contributor Author

@sylvestre It looks like the dist/{setup,show_stats}/index.js files were not rebuilt before the release so in reality v0.0.5 and v0.0.6 are running the same code.

I guess the release process should include npm run build and adding the generated dist files to the repo. (And yeah, it's a terrible design choice for Typescript Actions that generated code must be committed to the repo).

renovate bot added a commit to spiraldb/fastlanes that referenced this pull request Sep 27, 2024
)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
|
[mozilla-actions/sccache-action](https://redirect.github.com/mozilla-actions/sccache-action)
| action | patch | `v0.0.5` -> `v0.0.6` |

---

### Release Notes

<details>
<summary>mozilla-actions/sccache-action
(mozilla-actions/sccache-action)</summary>

###
[`v0.0.6`](https://redirect.github.com/Mozilla-Actions/sccache-action/releases/tag/v0.0.6)

[Compare
Source](https://redirect.github.com/mozilla-actions/sccache-action/compare/v0.0.5...v0.0.6)

##### What's Changed

- fix: string interpolation by
[@&#8203;i10416](https://redirect.github.com/i10416) in
[Mozilla-Actions/sccache-action#122
- Keep GitHub Actions up to date with GitHub's Dependabot by
[@&#8203;cclauss](https://redirect.github.com/cclauss) in
[Mozilla-Actions/sccache-action#131
- fix: avoid downloading package when local cache exists by
[@&#8203;i10416](https://redirect.github.com/i10416) in
[Mozilla-Actions/sccache-action#123
- Set baseUrl for Octokit to make it work on GitHub Enterprise Server by
[@&#8203;palloberg](https://redirect.github.com/palloberg) in
[Mozilla-Actions/sccache-action#144

##### dependencies

- Bump eslint-plugin-jest from 28.5.0 to 28.6.0 by
[@&#8203;dependabot](https://redirect.github.com/dependabot) in
[Mozilla-Actions/sccache-action#130
- Bump ts-jest from 29.1.4 to 29.2.2 by
[@&#8203;dependabot](https://redirect.github.com/dependabot) in
[Mozilla-Actions/sccache-action#134
- Bump [@&#8203;types/node](https://redirect.github.com/types/node) from
20.13.0 to 20.14.11 by
[@&#8203;dependabot](https://redirect.github.com/dependabot) in
[Mozilla-Actions/sccache-action#133
- Bump
[@&#8203;typescript-eslint/eslint-plugin](https://redirect.github.com/typescript-eslint/eslint-plugin)
from 7.8.0 to 7.16.1 by
[@&#8203;dependabot](https://redirect.github.com/dependabot) in
[Mozilla-Actions/sccache-action#132
- Bump typescript from 5.4.5 to 5.5.3 by
[@&#8203;dependabot](https://redirect.github.com/dependabot) in
[Mozilla-Actions/sccache-action#128
- Bump ts-jest from 29.2.2 to 29.2.5 by
[@&#8203;dependabot](https://redirect.github.com/dependabot) in
[Mozilla-Actions/sccache-action#141
- Bump eslint-plugin-prettier from 5.1.3 to 5.2.1 by
[@&#8203;dependabot](https://redirect.github.com/dependabot) in
[Mozilla-Actions/sccache-action#140
- Bump prettier from 3.3.2 to 3.3.3 by
[@&#8203;dependabot](https://redirect.github.com/dependabot) in
[Mozilla-Actions/sccache-action#136
- Bump typescript from 5.5.3 to 5.6.2 by
[@&#8203;dependabot](https://redirect.github.com/dependabot) in
[Mozilla-Actions/sccache-action#145

##### New Contributors

- [@&#8203;i10416](https://redirect.github.com/i10416) made their first
contribution in
[Mozilla-Actions/sccache-action#122
- [@&#8203;cclauss](https://redirect.github.com/cclauss) made their
first contribution in
[Mozilla-Actions/sccache-action#131
- [@&#8203;palloberg](https://redirect.github.com/palloberg) made their
first contribution in
[Mozilla-Actions/sccache-action#144

**Full Changelog**:
Mozilla-Actions/sccache-action@v0.0.5...v0.0.6

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR was generated by [Mend Renovate](https://mend.io/renovate/).
View the [repository job
log](https://developer.mend.io/github/spiraldb/fastlanes).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC45Ny4wIiwidXBkYXRlZEluVmVyIjoiMzguOTcuMCIsInRhcmdldEJyYW5jaCI6ImRldmVsb3AiLCJsYWJlbHMiOltdfQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Action failing on GitHub Enterprise server
2 participants