From 94591371be31c9a9171a1b2202a6a2e58ddec5f4 Mon Sep 17 00:00:00 2001 From: Erick Friis Date: Fri, 23 Feb 2024 11:00:48 -0800 Subject: [PATCH] infra: CI success for partner packages (#18037) Thank you for contributing to LangChain! - [ ] **PR title**: "package: description" - Where "package" is whichever of langchain, community, core, experimental, etc. is being modified. Use "docs: ..." for purely docs changes, "templates: ..." for template changes, "infra: ..." for CI changes. - Example: "community: add foobar LLM" - [ ] **PR message**: ***Delete this entire checklist*** and replace with - **Description:** a description of the change - **Issue:** the issue # it fixes, if applicable - **Dependencies:** any dependencies required for this change - **Twitter handle:** if your PR gets announced, and you'd like a mention, we'll gladly shout you out! - [ ] **Add tests and docs**: If you're adding a new integration, please include 1. a test for the integration, preferably unit tests that do not rely on network access, 2. an example notebook showing its use. It lives in `docs/docs/integrations` directory. - [ ] **Lint and test**: Run `make format`, `make lint` and `make test` from the root of the package(s) you've modified. See contribution guidelines for more: https://python.langchain.com/docs/contributing/ Additional guidelines: - Make sure optional dependencies are imported within a function. - Please do not add dependencies to pyproject.toml files (even optional ones) unless they are required for unit tests. - Most PRs should not touch more than one package. - Changes should be backwards compatible. - If you are adding something to community, do not re-import it in langchain. If no one reviews your PR within a few days, please @-mention one of baskaryan, efriis, eyurtsev, hwchase17. --- .github/workflows/check_diffs.yml | 23 ++++++++++------------- 1 file changed, 10 insertions(+), 13 deletions(-) diff --git a/.github/workflows/check_diffs.yml b/.github/workflows/check_diffs.yml index 7769b3df61d8508..d93dca4d96db55b 100644 --- a/.github/workflows/check_diffs.yml +++ b/.github/workflows/check_diffs.yml @@ -129,20 +129,17 @@ jobs: ci_success: name: "CI Success" needs: [build, lint, test, compile-integration-tests, dependencies, extended-tests] + if: | + always() runs-on: ubuntu-latest + env: + JOBS_JSON: ${{ toJSON(needs) }} + RESULTS_JSON: ${{ toJSON(needs.*.result) }} + EXIT_CODE: ${{!contains(needs.*.result, 'failure') && !contains(needs.*.result, 'cancelled') && '0' || '1'}} steps: - name: "CI Success" run: | - echo "Success" - exit 0 - # this one is just for visibility, where CI success step gets skipped - ci_failure: - name: "CI Failure" - needs: [build, lint, test, compile-integration-tests, dependencies, extended-tests] - if: ${{ !success() }} - runs-on: ubuntu-latest - steps: - - name: "CI Failure" - run: | - echo "Failure" - exit 1 + echo $JOBS_JSON + echo $RESULTS_JSON + echo "Exiting with $EXIT_CODE" + exit $EXIT_CODE