diff --git a/app/src/common/shared/org/mozilla/vrbrowser/ui/viewmodel/WindowViewModel.java b/app/src/common/shared/org/mozilla/vrbrowser/ui/viewmodel/WindowViewModel.java index 87a0a3fe0..e17993b6c 100644 --- a/app/src/common/shared/org/mozilla/vrbrowser/ui/viewmodel/WindowViewModel.java +++ b/app/src/common/shared/org/mozilla/vrbrowser/ui/viewmodel/WindowViewModel.java @@ -55,7 +55,6 @@ public class WindowViewModel extends AndroidViewModel { private MutableLiveData isMicrophoneEnabled; private MutableLiveData isBookmarked; private MutableLiveData isFocused; - private MutableLiveData isSpecialUrl; private MutableLiveData isUrlEmpty; private MutableLiveData isPopUpAvailable; private MutableLiveData canGoForward; @@ -130,7 +129,6 @@ public WindowViewModel(Application application) { isMicrophoneEnabled = new MutableLiveData<>(new ObservableBoolean(true)); isBookmarked = new MutableLiveData<>(new ObservableBoolean(false)); isFocused = new MutableLiveData<>(new ObservableBoolean(false)); - isSpecialUrl = new MutableLiveData<>(new ObservableBoolean(false)); isUrlEmpty = new MutableLiveData<>(new ObservableBoolean(false)); isPopUpAvailable = new MutableLiveData<>(new ObservableBoolean(false)); canGoForward = new MutableLiveData<>(new ObservableBoolean(false)); @@ -306,7 +304,6 @@ public void refresh() { isMicrophoneEnabled.postValue(isMicrophoneEnabled.getValue()); isBookmarked.postValue(isBookmarked.getValue()); isFocused.postValue(isFocused.getValue()); - isSpecialUrl.postValue(isSpecialUrl.getValue()); isUrlEmpty.postValue(isUrlEmpty.getValue()); isPopUpAvailable.postValue(isPopUpAvailable.getValue()); canGoForward.postValue(canGoForward.getValue()); @@ -393,8 +390,6 @@ public void setUrl(@Nullable Spannable url) { } } - setIsSpecialUrl(aURL.isEmpty()); - this.url.setValue(url); } @@ -560,15 +555,6 @@ public void setIsFocused(boolean isFocused) { this.isFocused.postValue(new ObservableBoolean(isFocused)); } - @NonNull - public MutableLiveData getIsSpecialUrl() { - return isSpecialUrl; - } - - public void setIsSpecialUrl(boolean isSpecialUrl) { - this.isSpecialUrl.postValue(new ObservableBoolean(isSpecialUrl)); - } - @NonNull public MutableLiveData getIsUrlEmpty() { return isUrlEmpty; diff --git a/app/src/common/shared/org/mozilla/vrbrowser/ui/views/NavigationURLBar.java b/app/src/common/shared/org/mozilla/vrbrowser/ui/views/NavigationURLBar.java index e35189e6e..c7aadc0f7 100644 --- a/app/src/common/shared/org/mozilla/vrbrowser/ui/views/NavigationURLBar.java +++ b/app/src/common/shared/org/mozilla/vrbrowser/ui/views/NavigationURLBar.java @@ -136,9 +136,8 @@ private void initialize(Context aContext) { }); mBinding.urlEditText.setOnFocusChangeListener((view, focused) -> { - boolean isUrlEmpty = mBinding.urlEditText.getText().length() == 0; mViewModel.setIsFocused(focused); - mViewModel.setIsUrlEmpty(isUrlEmpty); + mViewModel.setIsUrlEmpty(mBinding.urlEditText.getText().toString().isEmpty()); if (!focused) { hideSelectionMenu(); } else { @@ -430,9 +429,7 @@ public void beforeTextChanged(CharSequence charSequence, int i, int i1, int i2) @Override public void onTextChanged(CharSequence charSequence, int i, int i1, int i2) { - String aURL = mBinding.urlEditText.getText().toString(); - boolean empty = aURL.length() == 0 || aURL.startsWith("about://"); - mViewModel.setIsUrlEmpty(empty); + mViewModel.setIsUrlEmpty(mBinding.urlEditText.getText().toString().isEmpty()); } @Override diff --git a/app/src/main/res/layout/navigation_url.xml b/app/src/main/res/layout/navigation_url.xml index c18fe57f8..ebca9141b 100644 --- a/app/src/main/res/layout/navigation_url.xml +++ b/app/src/main/res/layout/navigation_url.xml @@ -40,8 +40,8 @@ + app:visibleGone="@{viewmodel.isFocused && !viewmodel.isUrlEmpty}" /> + android:layout_centerVertical="true" + app:visibleGone="@{!viewmodel.isFocused}"> + app:visibleGone="@{viewmodel.isInsecureVisible}" />