New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update FxR icon back ground to match other assets? #311

Closed
bluemarvin opened this Issue Aug 2, 2018 · 8 comments

Comments

Projects
5 participants
@bluemarvin
Collaborator

bluemarvin commented Aug 2, 2018

@thenadj currently the background for the various FxR icons is white. Should it be change to the same purple being used for the app store assets?

@bluemarvin bluemarvin added the Design label Aug 2, 2018

@thenadj

This comment has been minimized.

thenadj commented Aug 3, 2018

@bluemarvin Can you attach a screenshot so I can see what they currently look like? Where do they show up?

@bluemarvin

This comment has been minimized.

Collaborator

bluemarvin commented Aug 3, 2018

It's the icons from this issue: #197 (comment)

They all have white back grounds currently. I can take screen shots from devices tomorrow.

@thenadj

This comment has been minimized.

thenadj commented Aug 3, 2018

Where do they show up? If they are app icons on hardware devices, then I'd probably keep the background white. I'd have to see them in their final place to make the right decision.

@bluemarvin

This comment has been minimized.

Collaborator

bluemarvin commented Aug 3, 2018

@thenadj These are all small but hopefully you can see well enough.

I captured it in both Daydream and VIVEPort. Additionally, there is one showing it in the library, and one showing it in recently run for both platforms.

One thing I notice is that for some reason our icon is smaller than other app icons in VIVEPort so I'll create an issue to investigate that.

VIVEPort Library:
screen1
VIVEPort recently run:
screen2
Daydream Library:
screen4
Daydream recently run:
screen3

@nancyhang nancyhang added the P1 label Aug 3, 2018

@nancyhang nancyhang added this to the V1.0 milestone Aug 3, 2018

@nancyhang nancyhang added this to To do in v1.0 via automation Aug 3, 2018

@thenadj

This comment has been minimized.

thenadj commented Aug 7, 2018

@bluemarvin Use hex 25003E for background color. And adjust icon size to match other icons. Note that in top attached image icon is too small and in bottom attached image icon is too large.

@keianhzo

This comment has been minimized.

Collaborator

keianhzo commented Aug 7, 2018

Icon background color change is something that we can do using the Android assets manager. Regarding the sizes, all the icons are also generated by the assets manager so maybe there is some setting that is affecting the size on those devices.

@bluemarvin

This comment has been minimized.

Collaborator

bluemarvin commented Aug 9, 2018

fxandroid

Looks like they changed the size of the Fx logo. We should probably match that size when changing the background.

@thenadj

This comment has been minimized.

thenadj commented Aug 10, 2018

Yes, please match the size and placement for brand consistency.

v1.0 automation moved this from To do to Done Aug 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment