Make l10n paths more common, add l10n.toml config for checks #882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cvan
reviewed
Dec 7, 2018
| @@ -47,7 +47,7 @@ | |||
| <!-- This string will be displayed in a dialog box presented to the user when the application | |||
| needs to request permission to access the device's external storage such as the | |||
| sdcard. '%1$s' will be replaced at runtime with the website's domain name. --> | |||
| <string name="permission_persistent_storage">%S가 영구 저장 장치에 데이터를 저장하도록 허용하겠습니까?</string> | |||
| <string name="permission_persistent_storage">%s가 영구 저장 장치에 데이터를 저장하도록 허용하겠습니까?</string> | |||
There was a problem hiding this comment.
this a typo? should be %1$s, eh?
There was a problem hiding this comment.
Changed that. Both are OK, but it's better to be explicit and also consistent with the rest of the file.
|
@cvan, can you take another look? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not actually adding validators and l10n checks here, as I'm hoping for more consistent automation among the Android projects.
CC @Delphine for the string changes here, and generally "and now you know".
This patch is laying the foundation to include fxr into the l10n repo toolchain.