Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #834 #835 Bookmarks resize issues #888

Merged
merged 1 commit into from Dec 17, 2018
Merged

Fixes #834 #835 Bookmarks resize issues #888

merged 1 commit into from Dec 17, 2018

Conversation

keianhzo
Copy link
Collaborator

Fixes #834 #835 Fixed bookmarks resize issues and refactored browser and bookmarks code into a "browser window" widget so we just need to use a single surface texture for any view that belongs to the browser window space (bookmarks, history, browser, etc)

@cvan cvan added this to the v1.2 milestone Dec 14, 2018
Copy link
Contributor

@cvan cvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent! 👍 I tested, and this nicely fixes both #834 and #835.

P.S. I filed this nit issue that I forgot to file from earlier: issue #895

@MortimerGoro
Copy link
Contributor

MortimerGoro commented Dec 17, 2018

Tested and I didn't find any issue, good work!

Copy link
Contributor

@caseyyee caseyyee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@bluemarvin
Copy link
Contributor

Looks like this broke the bookmark page on every platform but Oculus.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants