Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable ETC2 compressed textures. Add asset compressor tool. #892

Merged
merged 1 commit into from Dec 14, 2018

Conversation

MortimerGoro
Copy link
Contributor

…w assets

@MortimerGoro
Copy link
Contributor Author

I need to also convert the controller model images, just forgot they are in different folders, I'll update the PR, but you can start the review already

@MortimerGoro
Copy link
Contributor Author

Already converted controller images

bluemarvin
bluemarvin previously approved these changes Dec 14, 2018
if (VRBrowser::isOverrideEnvPathEnabled()) {
std::string storagePath = VRBrowser::GetStorageAbsolutePath(INJECT_SKYBOX_PATH);
if (std::ifstream(storagePath)) {
skyboxPath = storagePath;
extension = ".jpg";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be great to either scan or allow user to specify extension. Definitely a followup, I believe there is already an issue on this.

@bluemarvin bluemarvin dismissed their stale review December 14, 2018 18:48

Skybox is broken on NoAPI

Copy link
Contributor

@bluemarvin bluemarvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NoAPI skybox is broken. Will test focus next.

@bluemarvin
Copy link
Contributor

Broken on Focus too.

@bluemarvin
Copy link
Contributor

Oops, forgot to update VRB, testing again 😔

@bluemarvin bluemarvin merged commit a24d68f into master Dec 14, 2018
@bluemarvin bluemarvin deleted the compressed_textures branch December 18, 2018 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants