New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSS development, a continuous lesson in humility #4

Open
Mpdreamz opened this Issue Mar 7, 2013 · 4 comments

Comments

Projects
None yet
3 participants
@Mpdreamz
Owner

Mpdreamz commented Mar 7, 2013

No description provided.

@dorony

This comment has been minimized.

Show comment
Hide comment
@dorony

dorony Mar 7, 2013

Thanks for the quick resolution of the issue! I love your library and it's awesome you maintain it so rigorously :)
I wanted to ask, though, why are you implementing your own synchronization code, instead of relying on built-in stuff like HttpClient.PostAsync? Won't that make your code simpler and easier to maintain?

dorony commented Mar 7, 2013

Thanks for the quick resolution of the issue! I love your library and it's awesome you maintain it so rigorously :)
I wanted to ask, though, why are you implementing your own synchronization code, instead of relying on built-in stuff like HttpClient.PostAsync? Won't that make your code simpler and easier to maintain?

@Mpdreamz

This comment has been minimized.

Show comment
Hide comment
@Mpdreamz

Mpdreamz Mar 7, 2013

Owner

Thanks for the kind words! Mostly because Iwanted to be in full control. Most of the code was written back when nest still supported .net 3.5. Somewhere last year i bumped to 4.0 but that still left HttpClient out of the picture, the other wrapper WebClient async stuff is event based which I personally think is more complicated then HttpWebRequest Begin_/End_ pattern.

It might be fun excersize to make a Nest.Connection.HttpClient45 project that has an IConnection that uses HttpClient though :)

Owner

Mpdreamz commented Mar 7, 2013

Thanks for the kind words! Mostly because Iwanted to be in full control. Most of the code was written back when nest still supported .net 3.5. Somewhere last year i bumped to 4.0 but that still left HttpClient out of the picture, the other wrapper WebClient async stuff is event based which I personally think is more complicated then HttpWebRequest Begin_/End_ pattern.

It might be fun excersize to make a Nest.Connection.HttpClient45 project that has an IConnection that uses HttpClient though :)

@inhies

This comment has been minimized.

Show comment
Hide comment
@inhies

inhies Oct 10, 2017

I just wanted to say I've missed you man, and hope you are doing well! I remember working with you was what really got me started programming <3

-Insert Name Here

inhies commented Oct 10, 2017

I just wanted to say I've missed you man, and hope you are doing well! I remember working with you was what really got me started programming <3

-Insert Name Here

@Mpdreamz

This comment has been minimized.

Show comment
Hide comment
@Mpdreamz

Mpdreamz Dec 9, 2017

Owner

@inhies wow, how awesome to hear from you man! So many fond memories of hacking on things over IRC with you 😄
We should catch up virtually, I don't really hang on IRC anymore but suggest a spot!

Super curious to hear where live took you this past decade :)

Owner

Mpdreamz commented Dec 9, 2017

@inhies wow, how awesome to hear from you man! So many fond memories of hacking on things over IRC with you 😄
We should catch up virtually, I don't really hang on IRC anymore but suggest a spot!

Super curious to hear where live took you this past decade :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment