OSS development, a continuous lesson in humility #4

Open
Mpdreamz opened this Issue Mar 7, 2013 · 2 comments

Projects

None yet

2 participants

@Mpdreamz
Owner
Mpdreamz commented Mar 7, 2013

No description provided.

@dorony
dorony commented Mar 7, 2013

Thanks for the quick resolution of the issue! I love your library and it's awesome you maintain it so rigorously :)
I wanted to ask, though, why are you implementing your own synchronization code, instead of relying on built-in stuff like HttpClient.PostAsync? Won't that make your code simpler and easier to maintain?

@Mpdreamz
Owner
Mpdreamz commented Mar 7, 2013

Thanks for the kind words! Mostly because Iwanted to be in full control. Most of the code was written back when nest still supported .net 3.5. Somewhere last year i bumped to 4.0 but that still left HttpClient out of the picture, the other wrapper WebClient async stuff is event based which I personally think is more complicated then HttpWebRequest Begin_/End_ pattern.

It might be fun excersize to make a Nest.Connection.HttpClient45 project that has an IConnection that uses HttpClient though :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment