Skip to content

[BUG] Incompatibility with Java pre version 14 #235

Description

@StepanOrt

Describe the bug
Mappie is not able to generate mappers from Java classes if run on with JVM language version that doesn't include Records (introduced in Java 14).

> Task :commons:compileKotlin
e: java.lang.NullPointerException
	at tech.mappie.ir.resolving.classes.sources.ImplicitClassMappingSourcesCollector.isJavaGetter(ImplicitClassMappingSourcesCollector.kt:43)
	at tech.mappie.ir.resolving.classes.sources.ImplicitClassMappingSourcesCollector.visitFunction(ImplicitClassMappingSourcesCollector.kt:27)
	at tech.mappie.ir.resolving.classes.sources.ImplicitClassMappingSourcesCollector.visitFunction(ImplicitClassMappingSourcesCollector.kt:17)
	at org.jetbrains.kotlin.ir.visitors.IrVisitor.visitSimpleFunction(IrVisitor.kt:65)
	at org.jetbrains.kotlin.ir.declarations.IrSimpleFunction.accept(IrSimpleFunction.kt:39)
	at tech.mappie.ir.util.BaseVisitor.accept(BaseVisitor.kt:15)
	at tech.mappie.ir.resolving.classes.sources.ImplicitClassMappingSourcesCollector.visitClass(ImplicitClassMappingSourcesCollector.kt:22)
	at tech.mappie.ir.resolving.classes.sources.ImplicitClassMappingSourcesCollector.visitClass(ImplicitClassMappingSourcesCollector.kt:17)

Line that throw exception:

if (parentAsClass.isSubclassOf(context.pluginContext.referenceClass(CLASS_ID_RECORD)!!)) {

The problem is that if SDK of Java doesn't contain class java.lang.Record, the function referenceClass is null and non-null assertion operator throws the exception. Solution is refactoring of the code with removal of assumption of non-null.

if (context.pluginContext.referenceClass(CLASS_ID_RECORD)?.let {  parentAsClass.isSubclassOf(it) } ?: false) {

Kotlin version
2.2.0

Mappie version
1.4.0

Mappie and Kotlin compatibility
yes

Invocation method
Gradle

Additional context
Tested on Java 11

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions