New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Waterfox 56.2.0 about:addons installs a wrong, inferior, version of an extension on FreeBSD #578
Comments
FreeBSD is not a platform officially supported by Waterfox. Can you reproduce the issue with a supported operating system? Please verify, otherwise a fix might be extremely hard to find, let alone done. |
AMO says "This add-on has been removed by its author."
Try replacing https://github.com/MrAlex94/Waterfox/blob/436898372f8589d4a241e924084119358c58bf45/toolkit/mozapps/extensions/internal/AddonRepository.jsm#L1226
Results don't appear to vary between platforms but
|
Thanks,
https://github.com/mozilla/addon-compatibility-reporter/releases/tag/2.2.4 (via the Notes section of https://redd.it/8c77ii – apologies for the omission).
Ah! … I forgot about … I'm not in a rush to follow-up. A head-spinning day with extensions (identifying a possible bug in Extension Conflict Troubleshooter, then using the extension to identify issues involving three others, etc.) so I probably need to sit on this issue 578 for a few days. Regain head space.
Pfft … the stuff that I wanted to spin off from there is no longer in my main profile. (I might have been trigger-happy with housekeeping a few months ago. Dug, found some screenshots from August 2017, not enough to jog my memory. Hopefully it'll come back when I get head space!) |
Oh, comments crossed paths, sorry yours didn't appear until after I posted mine. I'll probably take a look later in the week. Thanks again. |
@grahamperrin, can you reproduce using www/firefox-esr (while it tracks 52.*)? Even after mozilla/gecko-dev@aeee1208082b AMO can limit to specific platforms (i.e., |
Fixed by freebsd/freebsd-ports@83794bc14760. |
Assuming this fixes the issue, why don't you create a pull request for this? I think everyone using Waterfox on a platform not officially supported could profit here. Off-topic: Same goes for issue #416, there you have brought up a fix, but that fix never made it into the repository. Please, if you have a fix for any issue at hand, create a pull request for it. Otherwise the issue is never going to be fixed. |
@Peacock365, the fix here is a barely tested ugly hack which needs more work: conditionals to not break addon compatibility on Windows/macOS, submitting upstream (Firefox) for review and anything else I've missed due to unfamilarity with addon machinery. |
Ah, I see. In this case I assume it is better to wait until Mozilla has approved the fix (better safe than sorry). Off-topic II: Some love for issue #373 would be nice as well, as you can see here Mozilla didn't bother to fix the bug at this point: https://bugzilla.mozilla.org/show_bug.cgi?id=1415921#c0 If you could fix it this would be really nice. |
OK,
Maybe next week, although with time constraints etc. I can't promise. @jbeich in the meantime we have the positive test result https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=226919#c17 for (marginally outdated) www/waterfox 56.2.0.13_1. Big thanks.
A smart idea, however I'll defer any such request until after another issue (OT) is addressed. |
@jbeich I haven't found time (sorry), if I do then I'll follow up in a FreeBSD area.
I have not yet found what was lost, what I needed for the (non-FreeBSD-specific) spin-off issue. It's unlikely to resurface in the near future so we can close this issue 578. Thanks folks. |
Most of what's below is probably FreeBSD-specific, but this issue will spin off into something more general …
Steps
Expected
Actual result
Environment
Notes, thoughts
https://addons.mozilla.org/addon/disconnect/versions/ presents 5.18.21 as compatible:
– and https://addons.mozilla.org/en-GB/firefox/search/?q=disconnect&platform=FreeBSD&appver=56.2.0 does not find the Disconnect extension. @jbeich this is reminiscent of add-on services: Tier-3 platform BSD equivalence to Tier-1 Linux · Issue #4610 · mozilla/addons-frontend but that's a front-end issue so I'm taking care to not link on this occasion:
https://github.com/mozilla/addons-frontend/issues/4610
https://addons.mozilla.org/addon/disconnect/versions/?page=1#version-3.15.3.1-signed.1-signed presents the installed version as incompatible and:
Side notes
The 'no hint' parts of this issue
Maybe negligible. I think of Mozilla bug 1394225 - multiprocess (e10s) automatically enabled at launch after installing extensions that are not compatible with multiprocess, comment 2 in particular.
Yellow alerts
There's one here:
– so we might expect a user to be unsurprised by later discovery that what was installed is incompatible. However there's a complication …
The text was updated successfully, but these errors were encountered: