-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TCC support/ miniaudio update #27
Conversation
multiple changes for tinycc in stb updated miniaudio to 10.30 added a single ; to gs.h removed external dr headers now use internal miniaudio versions. new miniaudio versions have c89atomics built-in
Not sure what Is wrong but build is segfaulting on exit on linux. |
This is a threading issue, see #21 |
@@ -483,7 +483,7 @@ | |||
/*======================== | |||
// Defines | |||
========================*/ | |||
|
|||
; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove semi-colon here, unless it's needed for some reason? If so, then I'll need to find out why.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a a weird issue where tcc does not parse the initial headers properly if the semi colon is not there. The alternative is hiding it a few lines above or having tcc users add the semi-colon there.
impl/gs_audio_impl.h
Outdated
@@ -21,8 +22,8 @@ | |||
|
|||
// Includes | |||
#include "../external/stb/stb_vorbis.c" | |||
#include "../external/dr_libs/dr_wav.h" | |||
#include "../external/dr_libs/dr_mp3.h" | |||
#define MINIAUDIO_IMPLEMENTATION |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this moved outside of the miniaudio gs impl define? It needs to be encapsulated in that or else miniaudio will get implemented in all audio implementations.
Gonna leave this in my tcc branch not sure if its safe since msvc has some warning, but it should merge in master in the future if anyone needs it |
made some changes for tcc compilation.
Audio example tested and working on windows.
_wfindfirsti64 and _findfirst seem to compatible if that is a concern.
tested cl gcc and tcc