diff --git a/shell/browser/native_window_mac.mm b/shell/browser/native_window_mac.mm index e339366b05a2d..49f9dbdd88673 100644 --- a/shell/browser/native_window_mac.mm +++ b/shell/browser/native_window_mac.mm @@ -683,9 +683,6 @@ void ReorderChildWindowAbove(NSWindow* child_window, NSWindow* other_window) { } void NativeWindowMac::SetFullScreen(bool fullscreen) { - if (!has_frame() && !HasStyleMask(NSWindowStyleMaskTitled)) - return; - // [NSWindow -toggleFullScreen] is an asynchronous operation, which means // that it's possible to call it while a fullscreen transition is currently // in process. This can create weird behavior (incl. phantom windows), @@ -718,7 +715,8 @@ void ReorderChildWindowAbove(NSWindow* child_window, NSWindow* other_window) { ? FullScreenTransitionState::kEntering : FullScreenTransitionState::kExiting; - [window_ toggleFullScreenMode:nil]; + if (![window_ toggleFullScreenMode:nil]) + fullscreen_transition_state_ = FullScreenTransitionState::kNone; } bool NativeWindowMac::IsFullscreen() const { diff --git a/shell/browser/ui/cocoa/electron_ns_window.h b/shell/browser/ui/cocoa/electron_ns_window.h index 4256050d7e81d..502592313c15d 100644 --- a/shell/browser/ui/cocoa/electron_ns_window.h +++ b/shell/browser/ui/cocoa/electron_ns_window.h @@ -44,7 +44,7 @@ class ScopedDisableResize { - (electron::NativeWindowMac*)shell; - (id)accessibilityFocusedUIElement; - (NSRect)originalContentRectForFrameRect:(NSRect)frameRect; -- (void)toggleFullScreenMode:(id)sender; +- (BOOL)toggleFullScreenMode:(id)sender; - (NSImage*)_cornerMask; @end diff --git a/shell/browser/ui/cocoa/electron_ns_window.mm b/shell/browser/ui/cocoa/electron_ns_window.mm index ae4e96859b0ee..17adef63de825 100644 --- a/shell/browser/ui/cocoa/electron_ns_window.mm +++ b/shell/browser/ui/cocoa/electron_ns_window.mm @@ -334,7 +334,10 @@ - (void)performClose:(id)sender { } } -- (void)toggleFullScreenMode:(id)sender { +- (BOOL)toggleFullScreenMode:(id)sender { + if (!shell_->has_frame() && !shell_->HasStyleMask(NSWindowStyleMaskTitled)) + return NO; + bool is_simple_fs = shell_->IsSimpleFullScreen(); bool always_simple_fs = shell_->always_simple_fullscreen(); @@ -363,6 +366,8 @@ - (void)toggleFullScreenMode:(id)sender { bool maximizable = shell_->IsMaximizable(); shell_->SetMaximizable(maximizable); } + + return YES; } - (void)performMiniaturize:(id)sender {