From d4b3333f91bb94b1a765abae85cd33f270ba2743 Mon Sep 17 00:00:00 2001 From: Charles Kerr Date: Thu, 30 Nov 2023 05:41:48 -0600 Subject: [PATCH] build: fix release notes script bug that omitted edited release-clerk comments (#40634) * build: fix release notes script bug that omitted edited release-clerk comments add a warning when neither notes nor no-notes are found * fixup! build: fix release notes script bug that omitted edited release-clerk comments use console.warn() instead of console.log() --- script/release/notes/notes.js | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/script/release/notes/notes.js b/script/release/notes/notes.js index 282d502458144..7b2dc8392cb0c 100644 --- a/script/release/notes/notes.js +++ b/script/release/notes/notes.js @@ -99,7 +99,7 @@ const getNoteFromClerk = async (ghKey) => { const CLERK_LOGIN = 'release-clerk[bot]'; const CLERK_NO_NOTES = '**No Release Notes**'; - const PERSIST_LEAD = '**Release Notes Persisted**\n\n'; + const PERSIST_LEAD = '**Release Notes Persisted**'; const QUOTE_LEAD = '> '; for (const comment of comments.data.reverse()) { @@ -130,6 +130,8 @@ const getNoteFromClerk = async (ghKey) => { .trim(); } } + + console.warn(`WARN: no notes found in ${buildPullURL(ghKey)}`); }; /**