New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color Correction Ranges are clamped from 0-1 #1703

Closed
RichardULZ opened this Issue Dec 11, 2017 · 3 comments

Comments

Projects
None yet
2 participants
@RichardULZ

RichardULZ commented Dec 11, 2017

Problem

On the Color Correction node, the highlight selection range is clamped from 0-1.
This makes softly selecting and grading highlights of exr renders or hdr images hard.

Expected behavior:
Using the highlight control of color correct to softly pull down bright highlights on exr renders, by extending the highlight range above 1

Actual behavior:
The highlight range is clamped and will stop increasing power on values over 1

Steps to Reproduce

  1. Create a Color Wheel with edge value 0
  2. Create a Color Correct node and set the master gain to 2.0
  3. Create another Color Correct node and set the highlight gain to 0
  4. Go to the ranges tab and set the highlight range to x0.9 y0 and x1.1 y1

You will see an edge where the adjustment starts to darken values over 0.9, but will not increasingly darken values over 1, any rgb value over 1.1 should be black.

natron cc issue

Versions

  • Natron version/commit: 2.3.3 Release
  • OS version: Windows 7 x64
@devernay

This comment has been minimized.

Collaborator

devernay commented Dec 11, 2017

great bug report, thanks for the effort

devernay added a commit to MrKepzie/Natron-Tests that referenced this issue Dec 11, 2017

devernay added a commit to MrKepzie/Natron-Tests that referenced this issue Dec 11, 2017

@devernay

This comment has been minimized.

Collaborator

devernay commented Dec 11, 2017

please test with the latest build.

@RichardULZ

This comment has been minimized.

RichardULZ commented Dec 12, 2017

WOW! That was fast and it works flawlessly! Huge workflow improvement. Will be making more bug reports in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment