New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't seem to work with scoped packages #5

Closed
ProLoser opened this Issue Jun 25, 2018 · 4 comments

Comments

Projects
None yet
3 participants
@ProLoser

ProLoser commented Jun 25, 2018

I have several scoped symlinked packages and this doesn't recognize them.

@MrLoh

This comment has been minimized.

Owner

MrLoh commented Jun 26, 2018

Sorry, I'm not very familiar with scoped packages. I'd welcome a PR or at least a reproducible example how to setup a scoped package to test this with. In the issue facebook/metro#1 (comment) there was some indication in the discussion, that scoped packages might not work yet in general until some coming update.

@justinmakaila

This comment has been minimized.

Contributor

justinmakaila commented Jul 12, 2018

Scoped packages are essentially just subfolders in node_modules. The library currently reads the contents of node_modules and then just checks to see if any of the directories are symlinks.

I'm thinking to make this change, the library should instead load a package.json from the directory the command is being run in. It should pull the dependencies section from the json, get the keys, and then check to see if node_modules/{{dependencyName}} is a symlink, just like it does now.

@justinmakaila

This comment has been minimized.

Contributor

justinmakaila commented Jul 12, 2018

Implemented in #6. idk how to test it though, advice?

@MrLoh

This comment has been minimized.

Owner

MrLoh commented Aug 13, 2018

Implemented in #6

@MrLoh MrLoh closed this Aug 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment