GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
This is the patch for my posted issue at: #309
I tried using jsPDF (.debug.js and .min.js) with RequireJS (2.1.11). Everything works fine until I use grunt to build my webapp. After minification, my webapp break with error:
I found a workaround to this problem, by specifying what is called a stringID for that define() function:
requirejs patch for anonymous define()
Merging, and assuming this wouldn't cause a conflict for users using this approach.
Merge pull request #310 from vuongdothanhhuy/requirejs-patch
requirejs patch for anonymous define() - closes #288
This patch seems to have broken the ability to requirejs in the file. When I require in the latest version I get undefined however if I revert this change everything loads ok. Have you got any ideas? I know you are just naming the module so strange the impact it has had.
Thank you for your feedback. I'm also quite surprise how could one very simple and legal change can result in undefined in the latest requirejs. I will look into it as soon as I have time. Meanwhile, it would be very welcome if anyone can come and help us! (especially those who master AMD/requirejs).