From 1ab557f381b8aa1904557d39e7c96d1c915b38e2 Mon Sep 17 00:00:00 2001 From: Jonathan Ziller Date: Mon, 23 Jul 2018 22:11:19 +0200 Subject: [PATCH] fix: remove module augmentations for `requiredTrue` and `requiredFalse` validation errors since they conflict with the `required` module augmentation and are already covered by it --- validation/public_api.ts | 4 ++-- validation/src/required-false.ts | 11 ----------- validation/src/required-true.ts | 11 ----------- 3 files changed, 2 insertions(+), 24 deletions(-) diff --git a/validation/public_api.ts b/validation/public_api.ts index 4cd6893c..a076537a 100644 --- a/validation/public_api.ts +++ b/validation/public_api.ts @@ -16,5 +16,5 @@ export { minLength, MinLengthValidationError } from './src/min-length'; export { notEqualTo, NotEqualToValidationError } from './src/not-equal-to'; export { pattern, PatternValidationError } from './src/pattern'; export { required, RequiredValidationError } from './src/required'; -export { requiredFalse, RequiredFalseValidationError } from './src/required-false'; -export { requiredTrue, RequiredTrueValidationError } from './src/required-true'; +export { requiredFalse } from './src/required-false'; +export { requiredTrue } from './src/required-true'; diff --git a/validation/src/required-false.ts b/validation/src/required-false.ts index 26c0f132..30f19801 100644 --- a/validation/src/required-false.ts +++ b/validation/src/required-false.ts @@ -1,16 +1,5 @@ import { ValidationErrors } from 'ngrx-forms'; -export interface RequiredFalseValidationError { - actual: boolean; -} - -// @ts-ignore -declare module 'ngrx-forms/src/state' { - export interface ValidationErrors { - required?: RequiredFalseValidationError; - } -} - /** * A validation function that requires the value to be `false`. Considers `null` and * `undefined` as valid. Combine this function with the `required` validation diff --git a/validation/src/required-true.ts b/validation/src/required-true.ts index b7b2fe8a..a92a5e4b 100644 --- a/validation/src/required-true.ts +++ b/validation/src/required-true.ts @@ -1,16 +1,5 @@ import { ValidationErrors } from 'ngrx-forms'; -export interface RequiredTrueValidationError { - actual: boolean; -} - -// @ts-ignore -declare module 'ngrx-forms/src/state' { - export interface ValidationErrors { - required?: RequiredTrueValidationError; - } -} - /** * A validation function that requires the value to be `true`. Considers `null` and * `undefined` as valid. Combine this function with the `required` validation