Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning about validation #121

Closed
Mte90 opened this issue Oct 24, 2017 · 7 comments
Closed

Warning about validation #121

Mte90 opened this issue Oct 24, 2017 · 7 comments
Assignees
Milestone

Comments

@Mte90
Copy link
Owner

Mte90 commented Oct 24, 2017

If you are translating and press add translation you can get a warning if there are terms hightlighted.
In this workflow this is strange you need to get warnings about discard warnings if there aren't.

The ideal is to get warnings on add translation with a settings to disable it.

@Mte90 Mte90 self-assigned this Oct 24, 2017
@Mte90
Copy link
Owner Author

Mte90 commented Oct 30, 2017

I am trying to replicate the issue but is not happening for me with strings with terms when they are not available in the translated strings

@Mte90 Mte90 removed their assignment Oct 30, 2017
@Mte90 Mte90 closed this as completed Jun 24, 2018
@garretthyder
Copy link
Collaborator

Hey @Mte90 if this is the issue I think it is... then it's one of my personal frustrations with the GlotDict warnings and their need to be dismissed before submission.

I definitely find it jarring especially with certain Glossary Terms like 'Check' which only in monetary terms in 'Cheque' in en_CA. This one I find I have to dismiss two warnings to get anything submitted.

So if I start with a new translation with 'check' in the string but leave as is;
screen shot 2018-07-05 at 2 26 47 am

Then when I submit I get the alert;
screen shot 2018-07-05 at 2 26 54 am

And then I get the warning that I have to dismiss before submitting again;
screen shot 2018-07-05 at 2 27 00 am

This basically doubles the time for making this translation. I'd almost say drop the alert all together. or make it a dismissable gp notice as they're less intrusive and can be ignored.

@garretthyder garretthyder reopened this Jul 5, 2018
@Mte90
Copy link
Owner Author

Mte90 commented Jul 5, 2018

I agree if we can do that will be better, I added the alert to avoid errors with multiple warnings and to give tothe user an alert about what is happening instead nothing.

@Mte90 Mte90 added this to the 1.4 milestone Jul 5, 2018
@garretthyder
Copy link
Collaborator

Sounds good, I've self-assigned and will update to a gp notice.

One question I did have was the difference between a GlotPress and GlotDict warning is when they are triggered.
GlotPress - triggers after submit so doesn't block the action and add the entry to the Warnings view
GlotDict - triggers on submit and blocks the action

Is that a limitation of the extension as it's JS based so without a GlotPress update can't set persistent warnings on translations.

If persistent after-submit warnings are possible with GlotDict that might be a better option for the glossary warnings.

@garretthyder
Copy link
Collaborator

I've switched it to a GlotPress error notice and updated the verbiage for now.

If my other question is a possibility we can break it off into another ticket.

Mte90 pushed a commit that referenced this issue Jul 5, 2018
Reduces the amount of clicks required while still providing the error message to prompt users to dismiss and resubmit
Updates #121
@Mte90
Copy link
Owner Author

Mte90 commented Jul 5, 2018

I think that to simplify the extension code is better to not have persistent warnings because is something thatn eed to be implemented on GlotPRess.
For that reason I was blocking the execution of the GP warnings. Maybe we can ignore the GD but not GP because we don't have power on that.
In any case better to do another ticket :-)

@garretthyder
Copy link
Collaborator

Thanks @Mte90

I've branched into a new ticket for investigation, I don't feel it should be part of 1.4 though so can go into a future milestone for investigation and most likely will require an update to GlotPress to support it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants