New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing trailing space warning #129

Merged
merged 1 commit into from Jan 27, 2018

Conversation

Projects
None yet
2 participants
@audrasjb
Collaborator

audrasjb commented Jan 27, 2018

This introduce missing trailing space warnings.
It supports classic spaces as well as non-breaking space characters.

Related: see GlotPress/GlotPress-WP#863 (GlotPress repo)

audrasjb

@audrasjb audrasjb requested a review from Mte90 Jan 27, 2018

@audrasjb audrasjb self-assigned this Jan 27, 2018

@audrasjb

This comment has been minimized.

Collaborator

audrasjb commented Jan 27, 2018

@Mte90 I assigned you to review this PR because double-checks are always great and merely cause I'm wondering if you prefer to include the trailing space check to trailing punctuation existing function.
In my humble opinion it can be nice to separate these functions for future enhancement (like a grey background color on trailing space in preview).

Cheers,
Jb

@Mte90

This comment has been minimized.

Owner

Mte90 commented Jan 27, 2018

Seems good!

@Mte90 Mte90 merged commit 2005e97 into Mte90:master Jan 27, 2018

1 check passed

Codacy/PR Quality Review Good work! A positive pull request.
Details
@Mte90

This comment has been minimized.

Owner

Mte90 commented Jan 27, 2018

I will release a new version asap!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment