[pull] master from fyne-io:master#27
Merged
Merged
Conversation
Improve the VBox and HBox documentation
The boxlayout code was heap-allocating a slice of canvas objects to keep track of sliders. However, it only had to keep track of the count.
If it can be avoided
This reduce the time spend in lock from 6% to 4% which is not negligeable. From the trace, it seems that we are taking the RichText propertyLock to often and that cause another 2 points. Another PR should review those and reduce the amount of time calling the locking mechanism.
Jumping to a requested position was actually done on exact bundary, correct this.
Move refresh to repaint where appropriate And update on moves. Fixes #2205
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )