Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outlined and Filled versions for MudIconButton and MudIconToggleButton #1634

Closed
JonBunator opened this issue May 22, 2021 · 4 comments
Closed
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@JonBunator
Copy link
Member

Currently there are only icon buttons with variant=text. We should also introduce outlined and filled versions for MudIconButton and MudIconToggleButton. They could look something like this:
grafik

As suggested in https://github.com/Garderoben/MudBlazor/issues/1557#issuecomment-842313031

@JonBunator JonBunator added the enhancement New feature or request label May 22, 2021
@JonBunator
Copy link
Member Author

@IIARROWS is working on this feature (you can assign him). I moved the discussion to a new thread. I think this makes it easier.
How I already mentioned above. I think it would make sense if the new styles also apply to MudIconToggleButton. What do you think?

@henon
Copy link
Collaborator

henon commented May 22, 2021

Github doesn't give me an option to assign @IIARROWS. Maybe because he hasn't posted on this issue yet.

@IIARROWS
Copy link
Sponsor Contributor

IIARROWS commented May 22, 2021 via email

@JonBunator JonBunator changed the title Outline and Filled versions for MuIconButton and MudIconToggleButton Outline and Filled versions for MudIconButton and MudIconToggleButton May 22, 2021
@JonBunator JonBunator changed the title Outline and Filled versions for MudIconButton and MudIconToggleButton Outlined and Filled versions for MudIconButton and MudIconToggleButton May 22, 2021
henon pushed a commit that referenced this issue Jun 3, 2021
* Add outlined and filled variants to IconButton

* Fix ripple and add variant to MudToggleIconButton

* Propagate variant from MudMenu

* Restore doc change

* Remove ToggledVariant from ToggleIconButton
@henon
Copy link
Collaborator

henon commented Jun 3, 2021

PR merged.

@henon henon added this to the 5.0.11 milestone Jun 3, 2021
@henon henon closed this as completed Jun 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants