Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MudCheckBox Dense feature #1653

Closed
lskyum opened this issue May 24, 2021 · 7 comments · Fixed by #1970
Closed

MudCheckBox Dense feature #1653

lskyum opened this issue May 24, 2021 · 7 comments · Fixed by #1970
Labels
enhancement New feature or request priority-high

Comments

@lskyum
Copy link

lskyum commented May 24, 2021

Is your feature request related to a problem? Please describe.
Sometimes MudCheckBox takes up a lot of space because of the "hoover circle" around it. This makes it hard to make compact designs where a checkbox is part of it. Somehow MudTable manages to shink it's size anyway, but here the circle overlaps the other rows.

image

Describe the solution you'd like
A Dense="true" option on MudCheckBox would be awesome.

The smaller of the circles here are taken from material.io website:
image

Describe alternatives you've considered
A haven't found any workarounds yet...

@lskyum lskyum added the enhancement New feature or request label May 24, 2021
@porkopek
Copy link
Contributor

You can achieve this in your app with

label.mud-checkbox>.mud-icon-button {
    padding: 4px;
}

@lskyum
Copy link
Author

lskyum commented May 24, 2021

@porkopek Thanks for the workaround!

I made a small addition, so I can control which checkboxes it applies to:
https://try.mudblazor.com/snippet/QYcvaTmIrlRMOJtC

@porkopek
Copy link
Contributor

You did it right!

@marcmognol
Copy link
Contributor

Hi @lskyum ,

Maybe you can make a pull request? I am also interested in this Dense property.

Thanks in advance

@lskyum
Copy link
Author

lskyum commented May 26, 2021

@Heisenberg74
I may just make a PR eventually, but right now I'm too busy finishing a project.

@lskyum
Copy link
Author

lskyum commented May 28, 2021

Question: Would it make sense to add a Size instead of Dense? For example the same sizes as MudIconButton.
MudIconButton also scales the icon, but I guess MudCheckBox should not scale the checkbox itself?

@henon
Copy link
Collaborator

henon commented Jun 4, 2021

This issue is now organized in our feature requests project

Note: the issue is closed but that doesn't mean that this won't be implemented. Check the project to see how it is scheduled. If enough users vote for a different scheduling it can be changed. Also, if you want to PR this feature you may do so any time.

You can still discuss this feature here!

@henon henon closed this as completed Jun 4, 2021
@mikes-gh mikes-gh reopened this Jun 8, 2021
henon pushed a commit that referenced this issue Jun 23, 2021
* MudCheckBox added sizes, dense and improved docs fixed (#1653)

* Fixed wrong icon when not checked

* Added CSS class tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority-high
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants