Skip to content

Conversation

@sidneyxvr
Copy link
Contributor

Description

Part of #4896

Added more mudglobal defaults

  • Button - Variant
  • Input - Variant and Margin

How Has This Been Tested?

no tests were added, just following the merged prs related to mudglobal

Type of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (fix or improvement to the website or code docs)

Checklist

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@github-actions github-actions bot added enhancement Request for adding a new feature or enhancing existing functionality (not fixing a defect) PR: needs review labels Oct 14, 2024
@sidneyxvr sidneyxvr changed the title Add to mudglobal - Button and Input Add more defaults to mudglobal - Button and Input Oct 14, 2024
@codecov
Copy link

codecov bot commented Oct 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.06%. Comparing base (28bc599) to head (8ebe413).
Report is 603 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #10006      +/-   ##
==========================================
+ Coverage   89.82%   91.06%   +1.23%     
==========================================
  Files         412      410       -2     
  Lines       11878    12517     +639     
  Branches     2364     2446      +82     
==========================================
+ Hits        10670    11398     +728     
+ Misses        681      570     -111     
- Partials      527      549      +22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danielchalmers danielchalmers requested a review from henon October 20, 2024 16:13
@henon henon changed the title Add more defaults to mudglobal - Button and Input MudGlobal: Add more defaults for Button and Input Oct 21, 2024
@henon henon merged commit cc48517 into MudBlazor:dev Oct 21, 2024
4 checks passed
@henon
Copy link
Collaborator

henon commented Oct 21, 2024

Thanks @sidneyxvr

ScarletKuro pushed a commit that referenced this pull request Oct 29, 2024
LLauter pushed a commit to cannellamedia/MudBlazor that referenced this pull request Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Request for adding a new feature or enhancing existing functionality (not fixing a defect)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants