Skip to content

Conversation

@ScarletKuro
Copy link
Member

Description

Fixes: #9985

I think this should completely resolve the problem.

Type of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (fix or improvement to the website or code docs)

Checklist

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@github-actions github-actions bot added bug Unexpected behavior or functionality not working as intended PR: needs review labels Oct 14, 2024
@codecov
Copy link

codecov bot commented Oct 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.96%. Comparing base (28bc599) to head (b44011e).
Report is 571 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #10012      +/-   ##
==========================================
+ Coverage   89.82%   90.96%   +1.13%     
==========================================
  Files         412      409       -3     
  Lines       11878    12525     +647     
  Branches     2364     2446      +82     
==========================================
+ Hits        10670    11393     +723     
+ Misses        681      577     -104     
- Partials      527      555      +28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ScarletKuro ScarletKuro merged commit a413037 into MudBlazor:dev Oct 14, 2024
@ScarletKuro ScarletKuro deleted the improve_canceltoken branch October 14, 2024 10:45
ScarletKuro added a commit that referenced this pull request Oct 14, 2024
@ScarletKuro ScarletKuro changed the title BrowserViewportSubscription: Improve CancellationToken logic BrowserViewportService: Improve CancellationToken logic Oct 14, 2024
LLauter pushed a commit to cannellamedia/MudBlazor that referenced this pull request Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Unexpected behavior or functionality not working as intended

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MudDrawer Exception when rendering

1 participant