Skip to content

ObserverManager: Use ConcurrentDictionary#10023

Merged
ScarletKuro merged 1 commit intoMudBlazor:devfrom
ScarletKuro:observer
Oct 14, 2024
Merged

ObserverManager: Use ConcurrentDictionary#10023
ScarletKuro merged 1 commit intoMudBlazor:devfrom
ScarletKuro:observer

Conversation

@ScarletKuro
Copy link
Member

@ScarletKuro ScarletKuro commented Oct 14, 2024

Description

Use ConcurrentDictionary instead of Dictionary.
We wanted to use it before, but had some issues with it: #6981 (comment)
This is a lot better than copying the list.
I also decided the logs to be Trace type, since most people have Debug as their minimum even in prod.

How Has This Been Tested?

Type of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (fix or improvement to the website or code docs)

Checklist

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@github-actions github-actions bot added enhancement Adds a new feature or enhances existing functionality (not fixing a defect) in the main library PR: needs review labels Oct 14, 2024
@codecov
Copy link

codecov bot commented Oct 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.00%. Comparing base (2e29d6d) to head (ed09c02).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev   #10023   +/-   ##
=======================================
  Coverage   90.99%   91.00%           
=======================================
  Files         409      409           
  Lines       12508    12508           
  Branches     2442     2442           
=======================================
+ Hits        11382    11383    +1     
  Misses        573      573           
+ Partials      553      552    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ScarletKuro ScarletKuro merged commit 6f8a82b into MudBlazor:dev Oct 14, 2024
@ScarletKuro ScarletKuro deleted the observer branch October 14, 2024 16:41
LLauter pushed a commit to cannellamedia/MudBlazor that referenced this pull request Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Adds a new feature or enhances existing functionality (not fixing a defect) in the main library

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant