Skip to content

MudDataGrid: Fix regression in #9916 and #9801#10042

Merged
ScarletKuro merged 5 commits intoMudBlazor:devfrom
ScarletKuro:datagrid_fix
Oct 17, 2024
Merged

MudDataGrid: Fix regression in #9916 and #9801#10042
ScarletKuro merged 5 commits intoMudBlazor:devfrom
ScarletKuro:datagrid_fix

Conversation

@ScarletKuro
Copy link
Member

@ScarletKuro ScarletKuro commented Oct 16, 2024

Description

Fixes: #10041 Regression introduced in #9916
Fixes: #10034 Regression introduced in #9801

How Has This Been Tested?

Unit tests

Type of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (fix or improvement to the website or code docs)

Checklist

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@github-actions github-actions bot added bug Unexpected behavior or functionality not working as intended PR: needs review labels Oct 16, 2024
@codecov
Copy link

codecov bot commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.05%. Comparing base (e49460d) to head (c8376ca).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev   #10042   +/-   ##
=======================================
  Coverage   91.05%   91.05%           
=======================================
  Files         410      410           
  Lines       12451    12457    +6     
  Branches     2427     2428    +1     
=======================================
+ Hits        11337    11343    +6     
  Misses        566      566           
  Partials      548      548           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ScarletKuro ScarletKuro changed the title MudDataGrid: Fix regression in #9916 MudDataGrid: Fix regression in #9916 and #9801 Oct 16, 2024
@ScarletKuro ScarletKuro merged commit bb3759a into MudBlazor:dev Oct 17, 2024
@ScarletKuro ScarletKuro deleted the datagrid_fix branch October 17, 2024 10:02
ScarletKuro added a commit that referenced this pull request Oct 17, 2024
# Conflicts:
#	src/MudBlazor.UnitTests/Components/DataGridTests.cs
@0xced
Copy link
Contributor

0xced commented Oct 21, 2024

Thanks for fixing the regression I introduced in #9801, @ScarletKuro!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Unexpected behavior or functionality not working as intended

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MudDataGrid: Error with DateTimeOffset 7.9.0+ MudDataGrid clear filter bug

2 participants