-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Scroll services: Clean up, make implementations internal, add xmodoc #10048
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #10048 +/- ##
=======================================
Coverage 91.10% 91.10%
=======================================
Files 409 410 +1
Lines 12486 12488 +2
Branches 2423 2424 +1
=======================================
+ Hits 11375 11377 +2
Misses 566 566
Partials 545 545 ☔ View full report in Codecov by Sentry. |
Member
Author
|
Added to the v8 migration guide at #9953 |
LLauter
pushed a commit
to cannellamedia/MudBlazor
that referenced
this pull request
Dec 16, 2024
This was referenced Aug 18, 2025
This was referenced Oct 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improves overall code quality
The implementation should always be internal.
Removed
ScrollOptionsandScrollManagerExceptionas it wasn't used anywhere.Type of Changes
Checklist
dev).