Skip to content

Conversation

@ScarletKuro
Copy link
Member

@ScarletKuro ScarletKuro commented Oct 18, 2024

Description

Improves overall code quality
The implementation should always be internal.
Removed ScrollOptions and ScrollManagerException as it wasn't used anywhere.

Type of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (fix or improvement to the website or code docs)

Checklist

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@github-actions github-actions bot added breaking change This change will require consumer code updates PR: needs review labels Oct 18, 2024
@codecov
Copy link

codecov bot commented Oct 18, 2024

Codecov Report

Attention: Patch coverage is 79.16667% with 5 lines in your changes missing coverage. Please review.

Project coverage is 91.10%. Comparing base (ed81ebe) to head (8e6475f).

Files with missing lines Patch % Lines
src/MudBlazor/Services/Scroll/ScrollSpy.cs 0.00% 3 Missing ⚠️
src/MudBlazor/Services/Scroll/ScrollListener.cs 80.00% 0 Missing and 1 partial ⚠️
src/MudBlazor/Services/Scroll/ScrollManager.cs 88.88% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              dev   #10048   +/-   ##
=======================================
  Coverage   91.10%   91.10%           
=======================================
  Files         409      410    +1     
  Lines       12486    12488    +2     
  Branches     2423     2424    +1     
=======================================
+ Hits        11375    11377    +2     
  Misses        566      566           
  Partials      545      545           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ScarletKuro ScarletKuro merged commit 1f8e8a9 into MudBlazor:dev Oct 19, 2024
2 checks passed
@ScarletKuro ScarletKuro deleted the scroll_refactor branch October 19, 2024 08:16
@ScarletKuro ScarletKuro added the v8 label Oct 19, 2024
@ScarletKuro
Copy link
Member Author

Added to the v8 migration guide at #9953

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking change This change will require consumer code updates

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant