Skip to content

ResizeObserver: Clean up, make implementations internal, add xmodoc#10055

Merged
ScarletKuro merged 5 commits intoMudBlazor:devfrom
ScarletKuro:resize_cleanup
Oct 20, 2024
Merged

ResizeObserver: Clean up, make implementations internal, add xmodoc#10055
ScarletKuro merged 5 commits intoMudBlazor:devfrom
ScarletKuro:resize_cleanup

Conversation

@ScarletKuro
Copy link
Member

@ScarletKuro ScarletKuro commented Oct 19, 2024

Description

Improves overall code quality
The implementation should always be internal.
Removed IDiposable.

Type of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (fix or improvement to the website or code docs)

Checklist

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@github-actions github-actions bot added breaking change This change will require consumer code updates PR: needs review labels Oct 19, 2024
@ScarletKuro ScarletKuro added the v8 label Oct 19, 2024
@codecov
Copy link

codecov bot commented Oct 19, 2024

Codecov Report

Attention: Patch coverage is 92.85714% with 1 line in your changes missing coverage. Please review.

Project coverage is 91.17%. Comparing base (6ac51c8) to head (d9b53b3).
Report is 4 commits behind head on dev.

Files with missing lines Patch % Lines
...r/Services/ResizeObserver/ResizeObserverFactory.cs 83.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #10055      +/-   ##
==========================================
+ Coverage   91.10%   91.17%   +0.07%     
==========================================
  Files         410      410              
  Lines       12476    12471       -5     
  Branches     2421     2420       -1     
==========================================
+ Hits        11366    11371       +5     
+ Misses        565      555      -10     
  Partials      545      545              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jperson2000 jperson2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Just had one XML doc suggestion

@ScarletKuro
Copy link
Member Author

Added to the v8 migration guide at #9953

@ScarletKuro ScarletKuro merged commit 65c064b into MudBlazor:dev Oct 20, 2024
@ScarletKuro ScarletKuro deleted the resize_cleanup branch October 20, 2024 10:32
LLauter pushed a commit to cannellamedia/MudBlazor that referenced this pull request Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking change This change will require consumer code updates

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants