MudCollapse: Rework animation#10056
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #10056 +/- ##
==========================================
- Coverage 91.10% 91.04% -0.06%
==========================================
Files 410 410
Lines 12476 12467 -9
Branches 2421 2420 -1
==========================================
- Hits 11366 11351 -15
- Misses 565 572 +7
+ Partials 545 544 -1 ☔ View full report in Codecov by Sentry. |
ScarletKuro
left a comment
There was a problem hiding this comment.
LGTM, I absolutely love this.
|
cc @henon @jperson2000 @igotinfected if anyone wants to test anything visually, feel free |
henon
left a comment
There was a problem hiding this comment.
Awesome how much code could be removed by this change!
|
Added to the v8 migration guide at #9953 |
|
Great! Thank you |
|
Hi folks, migrating from 7.16 to 8.3, my MudCollapse components didn't expand/collapse anymore. Any thoughts? |
|
@bsallesp See if it works in an incognito tab. if so this is a browser cache issue. |
|
It works as expected in the docs - https://mudblazor.com/components/collapse#api |
|
on it |
|
You guys saved the day. Let me know If a can help with something else. I'm open for participating for new communities. See ya! |
We appreciate any help we can get. Whenever you see something that needs improving, even if it's just small corrections/improvements in the docs, just open a PR for it. Every little bit helps! |
|
Noy urgent, but, I'm trying to clean my browser cache (brave), specially things from Blazor 7. I accept suggestions. In meanwhile, using anonymous tab. |
Description
Fixes #8939 by reworking the animation entirely to use CSS transitions on a grid display as opposed to calculating the height through JavaScript. This should be more performant and stable.
Impacts other components like the Expansion Panels, Tree View, Nav Menu. I'd like it if someone with more experience with those components can try the new transition effect locally.
How Has This Been Tested?
visually
Type of Changes
Before: #8939 (comment)
After:
video6.mp4
Animation is now a static 300ms which is between 50% slower and 333% faster, depending on how tall the content was before.
CollapseState,_state,AnimationEndAsyncare now private but I don't believe I made any other breaking changes aside from rewriting the CSS obviously (but the CSS classes themselves are still the same).Checklist
dev).