Skip to content

Conversation

@danielchalmers
Copy link
Member

Description

  • Adds Ripple property, true by default, along with a switch in the NonLinear example to try it
  • The mud-step-disabled class was removed and now the disabled button attribute is used
  • The step button now has type="button" defined to fix accessibility warning
  • Makes styles use library mud-clickable
  • Ripple is now highlighted with the text color
  • Allows selection of the step text if it's not acting as a button

How Has This Been Tested?

unit

Type of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (fix or improvement to the website or code docs)
video6.mp4

Checklist

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@danielchalmers danielchalmers requested a review from henon October 20, 2024 01:31
@github-actions github-actions bot added enhancement Request for adding a new feature or enhancing existing functionality (not fixing a defect) PR: needs review labels Oct 20, 2024
@codecov
Copy link

codecov bot commented Oct 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.10%. Comparing base (6ac51c8) to head (6e0dab9).
Report is 2 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev   #10060   +/-   ##
=======================================
  Coverage   91.10%   91.10%           
=======================================
  Files         410      410           
  Lines       12476    12477    +1     
  Branches     2421     2421           
=======================================
+ Hits        11366    11367    +1     
  Misses        565      565           
  Partials      545      545           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@henon henon changed the title Stepper: Add opt-out Ripple property MudStepper: Add opt-out Ripple property Oct 20, 2024
@henon henon merged commit 5a08c01 into MudBlazor:dev Oct 20, 2024
2 checks passed
@henon
Copy link
Contributor

henon commented Oct 20, 2024

Good job. Thanks @danielchalmers !

@henon henon added hacktoberfest Hacktoberfest 2021 hacktoberfest-accepted Issues and PRs which were accepted as Hacktoberfest submissions hacktoberfest2024 and removed PR: needs review labels Oct 20, 2024
LLauter pushed a commit to cannellamedia/MudBlazor that referenced this pull request Dec 16, 2024
Co-authored-by: Meinrad Recheis <meinrad.recheis@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Request for adding a new feature or enhancing existing functionality (not fixing a defect) hacktoberfest Hacktoberfest 2021 hacktoberfest2024 hacktoberfest-accepted Issues and PRs which were accepted as Hacktoberfest submissions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants