Skip to content

JsEvent: Use IAsyncDisposable#10061

Merged
ScarletKuro merged 2 commits intoMudBlazor:devfrom
ScarletKuro:js_event_dispose
Oct 20, 2024
Merged

JsEvent: Use IAsyncDisposable#10061
ScarletKuro merged 2 commits intoMudBlazor:devfrom
ScarletKuro:js_event_dispose

Conversation

@ScarletKuro
Copy link
Copy Markdown
Member

Description

Logic aligns with the rest of the services

Type of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (fix or improvement to the website or code docs)

Checklist

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@github-actions github-actions bot added breaking change This change will require consumer code updates (ex: removes/changes a public API) PR: needs review labels Oct 20, 2024
@ScarletKuro
Copy link
Copy Markdown
Member Author

Added to the v8 migration guide at #9953

@codecov
Copy link
Copy Markdown

codecov bot commented Oct 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.17%. Comparing base (65c064b) to head (2b6ca16).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #10061      +/-   ##
==========================================
- Coverage   91.17%   91.17%   -0.01%     
==========================================
  Files         410      410              
  Lines       12471    12463       -8     
  Branches     2420     2419       -1     
==========================================
- Hits        11371    11363       -8     
  Misses        555      555              
  Partials      545      545              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ScarletKuro ScarletKuro merged commit 894ec1d into MudBlazor:dev Oct 20, 2024
@ScarletKuro ScarletKuro deleted the js_event_dispose branch October 20, 2024 11:11
LLauter pushed a commit to cannellamedia/MudBlazor that referenced this pull request Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking change This change will require consumer code updates (ex: removes/changes a public API)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant