Skip to content

Fix origin points that relied on previous defaults#10110

Merged
ScarletKuro merged 1 commit intoMudBlazor:devfrom
danielchalmers:fix-origin-points
Oct 28, 2024
Merged

Fix origin points that relied on previous defaults#10110
ScarletKuro merged 1 commit intoMudBlazor:devfrom
danielchalmers:fix-origin-points

Conversation

@danielchalmers
Copy link
Member

Description

Follows up on #10071 by fixing some origin points that were set assuming the other corresponding point was a certain value, which is now different. See #10106.

All examples except the DataGrid header menu which is now appropriately aligned to the left (different from v7).

How Has This Been Tested?

visually

Type of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (fix or improvement to the website or code docs)

Checklist

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@github-actions github-actions bot added bug Unexpected behavior or functionality not working as intended PR: needs review labels Oct 28, 2024
@codecov
Copy link

codecov bot commented Oct 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (dev@1a2a35f). Learn more about missing BASE report.
Report is 3 commits behind head on dev.

Additional details and impacted files
@@          Coverage Diff           @@
##             dev   #10110   +/-   ##
======================================
  Coverage       ?   91.17%           
======================================
  Files          ?      411           
  Lines          ?    12474           
  Branches       ?     2429           
======================================
  Hits           ?    11373           
  Misses         ?      557           
  Partials       ?      544           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danielchalmers danielchalmers changed the title Fix origin points Fix origin points that relied on previous defaults Oct 28, 2024
@ScarletKuro ScarletKuro merged commit e7bfd7e into MudBlazor:dev Oct 28, 2024
versile2 pushed a commit to versile2/MudBlazor that referenced this pull request Oct 31, 2024
LLauter pushed a commit to cannellamedia/MudBlazor that referenced this pull request Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Unexpected behavior or functionality not working as intended

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants