MudPagination: Use ParameterState#10154
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #10154 +/- ##
=======================================
Coverage 91.23% 91.24%
=======================================
Files 411 411
Lines 12479 12492 +13
Branches 2432 2434 +2
=======================================
+ Hits 11385 11398 +13
Misses 552 552
Partials 542 542 ☔ View full report in Codecov by Sentry. |
|
Btw, I’ve always wondered why we have three pagination components: |
|
Question is always if it's worth it. I have had negative experience with such refactorings because you couple components with each other which otherwise would be completely independent. It could be easier to break one or the other whenever changing the shared component or at least create more headache whenever a change is necessary in one but not the other etc. Hard to say, you might be right and make things simpler or you could make things worse. |
|
Thanks @ScarletKuro! |
You wouldn't really couple them. The DataGrid/Table wouldn't need to know anything about the Pagination component. All it would need to do is implement an interface that provides information such as the current number of items, the current page, and the total number of pages, they both already have this info. The Additionally, we could provide a |
Description
Let's make this component better
How Has This Been Tested?
Unit tests are working and visually checked
Type of Changes
Checklist
dev).