Skip to content

MudToggleGroup: Fix icon margins#10162

Merged
henon merged 2 commits into
MudBlazor:devfrom
danielchalmers:toggle-group-icon-margins
Nov 4, 2024
Merged

MudToggleGroup: Fix icon margins#10162
henon merged 2 commits into
MudBlazor:devfrom
danielchalmers:toggle-group-icon-margins

Conversation

@danielchalmers

Copy link
Copy Markdown
Member

Description

The checkmark icon didn't have enough padding on the side and touched the borders of the element.

How Has This Been Tested?

visually

Type of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (fix or improvement to the website or code docs)

Before

image

After

image

image

Nothing changed if you don't have the icon enabled

image

Checklist

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@github-actions github-actions Bot added breaking change This change will require consumer code updates (ex: removes/changes an API) bug Unexpected behavior or functionality not working as intended PR: needs review labels Nov 2, 2024
@danielchalmers

Copy link
Copy Markdown
Member Author

Migration Guide:

ToggleItem: The span containing the checkmark icon was removed and the icon is now a direct child of mud-button-label. Checkmark classes that were on the span have been moved to the icon as well.

@codecov

codecov Bot commented Nov 2, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.22%. Comparing base (2b54ce6) to head (4810506).
Report is 12 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #10162      +/-   ##
==========================================
- Coverage   91.24%   91.22%   -0.02%     
==========================================
  Files         411      411              
  Lines       12492    12492              
  Branches     2434     2434              
==========================================
- Hits        11398    11396       -2     
  Misses        552      552              
- Partials      542      544       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ScarletKuro ScarletKuro requested a review from henon November 2, 2024 09:15
@henon henon changed the title ToggleGroup: Fix icon margins MudToggleGroup: Fix icon margins Nov 4, 2024
@henon henon merged commit 43a996c into MudBlazor:dev Nov 4, 2024
@henon

henon commented Nov 4, 2024

Copy link
Copy Markdown
Contributor

Thanks @danielchalmers !

@henon

henon commented Nov 4, 2024

Copy link
Copy Markdown
Contributor

Added to v8.0.0 Migration Guide

LLauter pushed a commit to cannellamedia/MudBlazor that referenced this pull request Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking change This change will require consumer code updates (ex: removes/changes an API) bug Unexpected behavior or functionality not working as intended

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants