Skip to content

MudNavGroup: Add HeaderClass for title customization#10268

Merged
henon merged 5 commits intoMudBlazor:devfrom
Anu6is:MudNavGroup-Title-Customization
Nov 22, 2024
Merged

MudNavGroup: Add HeaderClass for title customization#10268
henon merged 5 commits intoMudBlazor:devfrom
Anu6is:MudNavGroup-Title-Customization

Conversation

@Anu6is
Copy link
Copy Markdown
Contributor

@Anu6is Anu6is commented Nov 18, 2024

Description

Adds TitleClass parameter, allowing users to customize the MudNavGroup title without affecting the nested group items

Resolves #10267

How Has This Been Tested?

Visually

Type of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (fix or improvement to the website or code docs)

Checklist

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@github-actions github-actions Bot added enhancement Adds a new feature or enhances existing functionality (not fixing a defect) in the main library PR: needs review labels Nov 18, 2024
@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.51%. Comparing base (286d80a) to head (4f2d792).
Report is 6 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev   #10268   +/-   ##
=======================================
  Coverage   91.51%   91.51%           
=======================================
  Files         414      414           
  Lines       12988    12989    +1     
  Branches     2452     2452           
=======================================
+ Hits        11886    11887    +1     
  Misses        555      555           
  Partials      547      547           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@w3ori
Copy link
Copy Markdown
Contributor

w3ori commented Nov 18, 2024

Thanks!

Comment thread src/MudBlazor/Components/NavMenu/MudNavGroup.razor.cs Outdated
Comment thread src/MudBlazor/Components/NavMenu/MudNavGroup.razor.cs Outdated
@ScarletKuro ScarletKuro requested a review from henon November 18, 2024 18:31
@Anu6is Anu6is changed the title Mud nav group title customization MudNavGroup: Title customization Nov 19, 2024
@sonarqubecloud
Copy link
Copy Markdown

@henon henon changed the title MudNavGroup: Title customization MudNavGroup: Add HeaderClass for title customization Nov 22, 2024
@henon henon merged commit 548c27e into MudBlazor:dev Nov 22, 2024
@henon
Copy link
Copy Markdown
Contributor

henon commented Nov 22, 2024

Thanks @Anu6is

@w3ori
Copy link
Copy Markdown
Contributor

w3ori commented Jan 20, 2025

Is it possible to add also HeaderStyle parameter?

@Anu6is
Copy link
Copy Markdown
Contributor Author

Anu6is commented Jan 20, 2025

Is it possible to add also HeaderStyle parameter?

You can create a css class with the style you want applied and add that to the HeaderClass. I believe Mud is moving away from adding numerous Style properties to the components and preferring the use of Class.

@w3ori
Copy link
Copy Markdown
Contributor

w3ori commented Jan 20, 2025

I will, thanks!

@Anu6is
Copy link
Copy Markdown
Contributor Author

Anu6is commented Jan 20, 2025

@w3ori note the original PR description notes adding TitleClass and TitleStyle however the Style was removed 289c43b after being reviewed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Adds a new feature or enhances existing functionality (not fixing a defect) in the main library

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MudNavGroup | Title backgorund color colors whole element

5 participants