Skip to content

MudSelect: Change Visibility of "_currentIcon" to Internal#10451

Merged
henon merged 1 commit intoMudBlazor:devfrom
jperson2000:feature/mudselect-currentitem-v8
Dec 15, 2024
Merged

MudSelect: Change Visibility of "_currentIcon" to Internal#10451
henon merged 1 commit intoMudBlazor:devfrom
jperson2000:feature/mudselect-currentitem-v8

Conversation

@jperson2000
Copy link
Copy Markdown
Contributor

@jperson2000 jperson2000 commented Dec 15, 2024

Description

This breaking change is proposed for V8, to change the visibility of MudSelect._currentIcon from public to internal. This member appears to be for internal use by the component.

How Has This Been Tested?

This was tested by running all unit tests to ensure they still complete properly after the change. Also, the "Select All" MudSelect example was tested, which exercises the _currentIcon property (for the "Select All" icon).

Type of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (fix or improvement to the website or code docs)

Checklist

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@github-actions github-actions Bot added breaking change This change will require consumer code updates (ex: removes/changes a public API) PR: needs review labels Dec 15, 2024
@jperson2000 jperson2000 requested a review from henon December 15, 2024 05:35
@sonarqubecloud
Copy link
Copy Markdown

@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.54%. Comparing base (25ea55f) to head (0e9a029).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev   #10451   +/-   ##
=======================================
  Coverage   91.53%   91.54%           
=======================================
  Files         418      418           
  Lines       13228    13228           
  Branches     2539     2539           
=======================================
+ Hits        12108    12109    +1     
  Misses        547      547           
+ Partials      573      572    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@henon henon merged commit 797e923 into MudBlazor:dev Dec 15, 2024
@henon henon mentioned this pull request Dec 15, 2024
@henon
Copy link
Copy Markdown
Contributor

henon commented Dec 15, 2024

Added to v8.0.0 Migration Guide
#9953

@jperson2000 jperson2000 deleted the feature/mudselect-currentitem-v8 branch December 15, 2024 17:29
LLauter pushed a commit to cannellamedia/MudBlazor that referenced this pull request Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking change This change will require consumer code updates (ex: removes/changes a public API)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants