Skip to content

MudDataGrid: Fix Column Options Popover FixedHeader positioning#10580

Merged
danielchalmers merged 4 commits into
MudBlazor:devfrom
versile2:fix/datagridfixedheaderpopovers
Jan 18, 2025
Merged

MudDataGrid: Fix Column Options Popover FixedHeader positioning#10580
danielchalmers merged 4 commits into
MudBlazor:devfrom
versile2:fix/datagridfixedheaderpopovers

Conversation

@versile2
Copy link
Copy Markdown
Contributor

@versile2 versile2 commented Jan 8, 2025 •
edited
Loading

Description

In accordance with #10292 added column options popover to the same area
Added Dense mode targetted CSS to both
Resolves #10575
Resolves #10571 as the popup will now come from the header
Some screenshots in first comment

How Has This Been Tested?

Visually, unit tests updated

Type of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (fix or improvement to the website or code docs)

Checklist

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@github-actions github-actions Bot added bug Unexpected behavior or functionality not working as intended PR: needs review labels Jan 8, 2025
@versile2
Copy link
Copy Markdown
Contributor Author

versile2 commented Jan 8, 2025

Previous:
image

Now:
image

Dense mode
image
image

@versile2 versile2 requested a review from ScarletKuro January 8, 2025 15:44
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Jan 8, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@unisar864 unisar864 mentioned this pull request Jan 9, 2025
Closed
9 tasks
@henon henon changed the title Fix Column Options Popover FixedHeader positioning MudDataGrid: Fix Column Options Popover FixedHeader positioning Jan 11, 2025
@henon henon requested a review from danielchalmers January 13, 2025 19:15
danielchalmers
danielchalmers approved these changes Jan 13, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@danielchalmers danielchalmers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks right

@ScarletKuro ScarletKuro added the v8 label Jan 15, 2025
@danielchalmers danielchalmers merged commit ee5edca into MudBlazor:dev Jan 18, 2025
@seedysoft seedysoft mentioned this pull request Jan 27, 2025
Merged
@versile2 versile2 deleted the fix/datagridfixedheaderpopovers branch January 30, 2025 14:23
@dependabot dependabot Bot mentioned this pull request Aug 1, 2025
Closed
This was referenced Aug 18, 2025
Closed
Merged
@dependabot dependabot Bot mentioned this pull request Aug 27, 2025
Merged
@dependabot dependabot Bot mentioned this pull request Sep 8, 2025
Closed
@dependabot dependabot Bot mentioned this pull request Sep 22, 2025
Closed
This was referenced Oct 5, 2025
Merged
Open
Open
@dependabot dependabot Bot mentioned this pull request Nov 3, 2025
Merged
@dependabot dependabot Bot mentioned this pull request Nov 12, 2025
Closed
@dependabot dependabot Bot mentioned this pull request Dec 21, 2025
Closed
This was referenced Dec 29, 2025
Closed
Closed
This was referenced Jan 9, 2026
Closed
Closed
Closed
Merged
This was referenced Feb 23, 2026
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danielchalmers danielchalmers danielchalmers approved these changes

@ScarletKuro ScarletKuro Awaiting requested review from ScarletKuro

Assignees

No one assigned

Labels

bug Unexpected behavior or functionality not working as intended

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

MudDataGrid: Column panel position goes off screen when scrolled down and FixedHeader=true MudDataGrid problems

3 participants

@versile2 @danielchalmers @ScarletKuro