Skip to content

MudDataGrid: remove detrimental ChildRowContent CSS#10581

Merged
danielchalmers merged 3 commits intoMudBlazor:devfrom
versile2:fix/mudinputinsidedatagrid
Jan 21, 2025
Merged

MudDataGrid: remove detrimental ChildRowContent CSS#10581
danielchalmers merged 3 commits intoMudBlazor:devfrom
versile2:fix/mudinputinsidedatagrid

Conversation

@versile2
Copy link
Copy Markdown
Contributor

@versile2 versile2 commented Jan 8, 2025

Description

DataGrid uses CSS to alter the mud-input's it is using for it's cell and cell editing functions. I introduced a css class that ignores the margin portion of that style mud-table-child-content . I applied that class to the two places in the razor file it absorbs ChildRowContent. Also anytime a dev wants to use a mudtextfield with label they can now just add mud-table-child-content to the CellClass and it will not scrunch the settings.
Resolves #10351

How Has This Been Tested?

Visually, unit tests still operate. Before and After in first comment.

Type of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (fix or improvement to the website or code docs)

Checklist

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@github-actions github-actions Bot added bug Unexpected behavior or functionality not working as intended enhancement Adds a new feature or enhances existing functionality (not fixing a defect) in the main library PR: needs review labels Jan 8, 2025
@versile2
Copy link
Copy Markdown
Contributor Author

versile2 commented Jan 8, 2025

Before
Screenshot 2025-01-08 145801

After
Screenshot 2025-01-08 145812

Comment thread src/MudBlazor/Components/DataGrid/MudDataGrid.razor Outdated
Comment thread src/MudBlazor/Components/DataGrid/MudDataGrid.razor Outdated
@ScarletKuro
Copy link
Copy Markdown
Member

Please, add before and after pic.

@versile2
Copy link
Copy Markdown
Contributor Author

versile2 commented Jan 9, 2025

Please, add before and after pic.

before and after in first comment?

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Jan 9, 2025

@versile2 versile2 requested a review from ScarletKuro January 13, 2025 19:19
@danielchalmers
Copy link
Copy Markdown
Member

Will review after v8 is out

@ScarletKuro ScarletKuro added the v8 label Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Unexpected behavior or functionality not working as intended enhancement Adds a new feature or enhances existing functionality (not fixing a defect) in the main library

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MudDataGrid | Component labels shifted down vertically in row detail view.

3 participants