Skip to content

MudTextField: Fix line height for outlined frame#10649

Merged
danielchalmers merged 2 commits into
MudBlazor:devfrom
Apflkuacha:dev
Jan 18, 2025
Merged

MudTextField: Fix line height for outlined frame#10649
danielchalmers merged 2 commits into
MudBlazor:devfrom
Apflkuacha:dev

Conversation

@Apflkuacha
Copy link
Copy Markdown
Contributor

Description

The text on a outlined MudTextField is cropped at the bottom for letters who go below the textline, e.g. g,y,j,q,p,..
It could be seen in the official documentation, the 'g' of "Single select" is cut.
It could also be seen in the screenshot, especially at the 'g' in the end of the string "QjpqyLlg".

lineHeight18

How Has This Been Tested?

visually

lineHeight19

Type of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (fix or improvement to the website or code docs)

Checklist

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@github-actions github-actions Bot added bug Unexpected behavior or functionality not working as intended PR: needs review labels Jan 18, 2025
@danielchalmers
Copy link
Copy Markdown
Member

Good find. Could you try 1.15rem, approximately 18.4, like https://m2.material.io/components/text-fields has in .mdc-floating-label.

@Apflkuacha
Copy link
Copy Markdown
Contributor Author

Just tested and updated the PR, 1.15rem also look perfect.

@sonarqubecloud
Copy link
Copy Markdown

@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.79%. Comparing base (2a7377b) to head (3cbe22b).
Report is 6 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev   #10649   +/-   ##
=======================================
  Coverage   91.79%   91.79%           
=======================================
  Files         426      426           
  Lines       13378    13386    +8     
  Branches     2575     2576    +1     
=======================================
+ Hits        12280    12288    +8     
  Misses        527      527           
  Partials      571      571           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danielchalmers
Copy link
Copy Markdown
Member

Thank you!

@danielchalmers danielchalmers changed the title TextField: Fix line height for outlined frame MudTextField: Fix line height for outlined frame Jan 18, 2025
@danielchalmers danielchalmers merged commit 6a83f9c into MudBlazor:dev Jan 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Unexpected behavior or functionality not working as intended

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants