Skip to content

MudInput: Fix outline label conflict with third-party CSS#10672

Merged
danielchalmers merged 1 commit into
MudBlazor:devfrom
danielchalmers:mud-input-legend-float
Jan 21, 2025
Merged

MudInput: Fix outline label conflict with third-party CSS#10672
danielchalmers merged 1 commit into
MudBlazor:devfrom
danielchalmers:mud-input-legend-float

Conversation

@danielchalmers
Copy link
Copy Markdown
Member

Description

Fixes an issue mentioned in #10653 (comment) where Bootstrap CSS was setting a default value for float on legend elements which caused ours to render incorrectly since #10385.

Now we apply a reset on the aforementioned property using a deeper selector which should take precedence (haven't actually tested with bootstrap).

How Has This Been Tested?

visually

Type of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (fix or improvement to the website or code docs)

Before:

image

After:

image

Checklist

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@github-actions github-actions Bot added bug Unexpected behavior or functionality not working as intended PR: needs review labels Jan 21, 2025
@sonarqubecloud
Copy link
Copy Markdown

@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.79%. Comparing base (f7f07fe) to head (fc86a2a).
Report is 43 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #10672      +/-   ##
==========================================
+ Coverage   91.55%   91.79%   +0.23%     
==========================================
  Files         426      426              
  Lines       13305    13386      +81     
  Branches     2565     2576      +11     
==========================================
+ Hits        12182    12288     +106     
+ Misses        548      527      -21     
+ Partials      575      571       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danielchalmers danielchalmers merged commit 2bddaa3 into MudBlazor:dev Jan 21, 2025
@danielchalmers danielchalmers deleted the mud-input-legend-float branch January 21, 2025 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Unexpected behavior or functionality not working as intended

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants