MudInput: Fix outline label conflict with third-party CSS#10672
Merged
danielchalmers merged 1 commit intoJan 21, 2025
Conversation
4 tasks
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #10672 +/- ##
==========================================
+ Coverage 91.55% 91.79% +0.23%
==========================================
Files 426 426
Lines 13305 13386 +81
Branches 2565 2576 +11
==========================================
+ Hits 12182 12288 +106
+ Misses 548 527 -21
+ Partials 575 571 -4 ☔ View full report in Codecov by Sentry. |
ScarletKuro
approved these changes
Jan 21, 2025
This was referenced Aug 18, 2025
This was referenced Oct 5, 2025
This was referenced Dec 29, 2025
This was referenced Jan 9, 2026
This was referenced Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Fixes an issue mentioned in #10653 (comment) where Bootstrap CSS was setting a default value for
floatonlegendelements which caused ours to render incorrectly since #10385.Now we apply a reset on the aforementioned property using a deeper selector which should take precedence (haven't actually tested with bootstrap).
How Has This Been Tested?
visually
Type of Changes
Before:
After:
Checklist
dev).