Skip to content

MudInput: Fix legend style incorrectly inherited to child components#10683

Merged
danielchalmers merged 2 commits intoMudBlazor:devfrom
charles7668:fix/fix-legend
Jan 22, 2025
Merged

MudInput: Fix legend style incorrectly inherited to child components#10683
danielchalmers merged 2 commits intoMudBlazor:devfrom
charles7668:fix/fix-legend

Conversation

@charles7668
Copy link
Contributor

@charles7668 charles7668 commented Jan 22, 2025

Description

Close #10681

How Has This Been Tested?

Add a test viewer page named TextFieldNestedInFieldTest

Type of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (fix or improvement to the website or code docs)

msedge_sxUJVyF5qN

Checklist

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@github-actions github-actions bot added bug Unexpected behavior or functionality not working as intended PR: needs review labels Jan 22, 2025
@codecov
Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.80%. Comparing base (f20e5ff) to head (fe6fae6).
Report is 2 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev   #10683   +/-   ##
=======================================
  Coverage   91.79%   91.80%           
=======================================
  Files         426      426           
  Lines       13389    13400   +11     
  Branches     2577     2578    +1     
=======================================
+ Hits        12291    12302   +11     
  Misses        527      527           
  Partials      571      571           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Anu6is Anu6is requested a review from danielchalmers January 22, 2025 01:43
@Anu6is
Copy link
Contributor

Anu6is commented Jan 22, 2025

Can you add the nested example to the test viewer with the others

@sonarqubecloud
Copy link

@charles7668
Copy link
Contributor Author

Can you add the nested example to the test viewer with the others

Added

@danielchalmers danielchalmers changed the title MudInput: Fix the issue where the legend style was incorrectly inherit to child components. MudInput: Fix legend style incorrectly inherited to child components Jan 22, 2025
@danielchalmers
Copy link
Member

Fantastic, thanks for the quick fix.

@danielchalmers danielchalmers merged commit 6b6558c into MudBlazor:dev Jan 22, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Unexpected behavior or functionality not working as intended

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Visual issue with fields inside a MudField Component

4 participants