Skip to content

Select: Don't open while scrolling via touch#10718

Merged
ScarletKuro merged 6 commits into
MudBlazor:devfrom
danielchalmers:autocomplete-touch-down
Jan 26, 2025
Merged

Select: Don't open while scrolling via touch#10718
ScarletKuro merged 6 commits into
MudBlazor:devfrom
danielchalmers:autocomplete-touch-down

Conversation

@danielchalmers
Copy link
Copy Markdown
Member

@danielchalmers danielchalmers commented Jan 26, 2025

Fixes #10716
Refines #10129
Reverts #10353

The onmousedown event now toggles the menu instead of onpointerdown so panning the page with a touch input does't trigger it. The onclick event was added back to handle that case.

@ScarletKuro ScarletKuro added the bug Unexpected behavior or functionality not working as intended label Jan 26, 2025
@sonarqubecloud
Copy link
Copy Markdown

@ScarletKuro
Copy link
Copy Markdown
Member

Probably related, but on firefox https://www.mudblazor.com/components/select#custom-converter
when you open select, it instantly closes.

versile2 added a commit to versile2/MudBlazor that referenced this pull request Jan 27, 2025
versile2 added a commit to versile2/MudBlazor that referenced this pull request Jan 27, 2025
versile2 added a commit to versile2/MudBlazor that referenced this pull request Jan 29, 2025
@gabephudson
Copy link
Copy Markdown
Contributor

We noticed that all our MudSelects stopped opening when clicked on Android (Edge/Chrome are all I tested) when moving from 8.0 to 8.1. I'm not sure the cause, but I rolled back to 8.0 and they now work again. (I cleared the cache, tried incognito, etc. on mobile).

Not sure if this change is the cause, but I figured this was the most likely candidate. Posting here before I submit an issue.

Note that the selects appear to work correctly in the Mudblazor docs. Are they on 8.1?

@danielchalmers
Copy link
Copy Markdown
Member Author

We noticed that all our MudSelects stopped opening when clicked on Android (Edge/Chrome are all I tested) when moving from 8.0 to 8.1. I'm not sure the cause, but I rolled back to 8.0 and they now work again. (I cleared the cache, tried incognito, etc. on mobile).

Not sure if this change is the cause, but I figured this was the most likely candidate. Posting here before I submit an issue.

Note that the selects appear to work correctly in the Mudblazor docs. Are they on 8.1?

@gabephudson We just released v8.2.0, could you take a look and let me know if the selects and the docs work for you?

@gabephudson
Copy link
Copy Markdown
Contributor

@gabephudson We just released v8.2.0, could you take a look and let me know if the selects and the docs work for you?

8.2 has corrected the issue. Great timing! ;)

Thanks for the quick reply!

@danielchalmers
Copy link
Copy Markdown
Member Author

@gabephudson We just released v8.2.0, could you take a look and let me know if the selects and the docs work for you?

8.2 has corrected the issue. Great timing! ;)

Thanks for the quick reply!

Fantastic! Always appreciate the solid reports

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Unexpected behavior or functionality not working as intended

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Changes to MudSelect in v8 break page behavior on mobile

3 participants